Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Outage tasks for 2022-12-15 #807

Closed
6 of 7 tasks
kltm opened this issue Dec 2, 2022 · 12 comments
Closed
6 of 7 tasks

Outage tasks for 2022-12-15 #807

kltm opened this issue Dec 2, 2022 · 12 comments

Comments

@kltm
Copy link
Member

kltm commented Dec 2, 2022

@kltm
Copy link
Member Author

kltm commented Dec 14, 2022

@vanaukenk The report is completed

@kltm kltm moved this from Discussion to Working in Ongoing data QC and pipeline maintenance Dec 14, 2022
@vanaukenk
Copy link

I've checked over the diff and most of the updates are okay and consistent with the work in these two ontology tickets:
geneontology/go-ontology#24152
geneontology/go-ontology#24486

However, we also have two automatic model updates in which a BP term is being replaced by an MF term, as a result of the work in this ticket:
geneontology/go-ontology#24546

This update will result in either logically incorrect models or models with possibly incorrect biological information.
The two models affected are:
http://noctua.geneontology.org/editor/graph/gomodel:R-HSA-5221030
http://noctua.geneontology.org/editor/graph/gomodel:63894f2500001622

For the Reactome model, presumably this will be corrected with the next Reactome import, but for the second, mouse model, I think an MGI curator will need to review the model after the update to fix it.

I'm not sure how we should handle these types of replacements, i.e. MF for BP, in the future as they will likely result in similarly incorrect models.

@kltm @ukemi @cmungall @pgaudet @deustp01 @balhoff

@kltm
Copy link
Member Author

kltm commented Dec 14, 2022

@vanaukenk I think you might be thinking more of the day-to-day but, not to sound like a broken record, this would be in the scope of geneontology/project-management#47. Theoretically, I assume that we'd go ahead with the breakages, but have fixing them be a high priority; larger changes would be shelved until there was enough resources to accomplish them. We would also be able to continuously run these checks against new versions of the ontology, so there would be more lead time and a way of testing changes.

@vanaukenk
Copy link

vanaukenk commented Dec 14, 2022

I think you might be thinking more of the day-to-day

@kltm I'm actually thinking more about the consequence of replacing a term from one ontology with another, i.e. BP with MF, and whether we should do that in the ontology or whether these types of changes should instead make use of the 'consider' tag.

@kltm
Copy link
Member Author

kltm commented Dec 14, 2022

@vanaukenk Is a main consequence under consideration that we'd be building up a body of "broken" (i.e. shex-illegal) models and what to do with them? Or is this purely a best practices for the ontology and how migrations operate? (If the latter, I'll hide this off-topic subthread.)

@vanaukenk
Copy link

@kltm and I talked about this.
We will go ahead with the model updates and alert the MGI curator to manually review the model post-update.
We'd also like to talk this finding over with the ontology editors to see what they think is the best thing to do going forward.

@pgaudet
Copy link

pgaudet commented Dec 15, 2022

I shouldnt have replaced a BP by a MF, I'll change that

@vanaukenk
Copy link

Thanks @pgaudet

@ukemi
Copy link

ukemi commented Dec 15, 2022

I went in and removed the mouse annotations.

@vanaukenk
Copy link

@deustp01
Copy link

deustp01 commented Dec 15, 2022

For Reactome see comment in #26546

@vanaukenk
Copy link

@kltm - I'm closing this outage ticket in favor of any new work going into the next outage ticket #811

@kltm kltm moved this from Working to Done in Ongoing data QC and pipeline maintenance Feb 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

5 participants