Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EquivalentNodesSet.representativeNodeId() is not used in production code #61

Open
julesjacobsen opened this issue Feb 27, 2020 · 1 comment

Comments

@julesjacobsen
Copy link
Collaborator

EquivalentNodesSet.representativeNodeId() is used in the unit test, but never set in the production code. The EquivalentNodesSet is only used in FromOwl:

// all classes in equivalence axiom are named
// TODO: merge pairwise assertions into a clique
EquivalentNodesSet enset =
new EquivalentNodesSet.Builder().nodeIds(xClassIds).build();

Is this method really required as a setter? Seems it could be a default method to just choose the first if never set.

@cmungall
Copy link
Member

perhaps we could even remove this from the schema?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants