Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Confirm correct directionality of Physical Entity regulates Function assertions #18

Closed
goodb opened this issue Sep 4, 2018 · 4 comments
Assignees

Comments

@goodb
Copy link
Contributor

goodb commented Sep 4, 2018

I’m not sure where the “involved in positive regulation of [entity]” triplets are coming from. In GO-CAM a process/function can be regulated but not an entity, so we’d need a way to fix that if we want to keep it. But I can’t see how this comes out of the Reactome representation.

See e.g. 'Beta-catenin is released from the destruction complex' in http://noctua-dev.berkeleybop.org/editor/graph/gomodel:-80976963

@goodb goodb self-assigned this Sep 4, 2018
@goodb
Copy link
Contributor Author

goodb commented Sep 4, 2018

To get this converted to GO-CAM, you can try modifying your rule to link the activity that creates the physical entity, rather than the entity itself. So in your example, if physical_entity is an output of reaction_A, then reaction_A directly_negatively_regulates reaction.

@goodb
Copy link
Contributor Author

goodb commented Sep 7, 2018

The 'physical entity' involved in regulation of 'function' relations are correct but the UI reverses them in the folded view - see geneontology/noctua#582

These reflect physical controllers from, e.g. Reactome, that are not catalysts but exert some other form of regulatory control.

Leaving this issue open to explore the modification above to produce function regulates function assertions.

@goodb
Copy link
Contributor Author

goodb commented Sep 10, 2018

Forgot, this rule is actually already in place. See rule slides 14 and 15 in https://docs.google.com/presentation/d/1_UAQN09WPCA5win5mbMs1ORMALNwiRwMBgZDPuyJEW8/edit?slide=id.g355425beec_0_3#slide=id.g360932a148_0_36

You can see in the reaction linked above that "Beta-catenin is released from the destruction complex" is positively regulated by 'Phosphorylation of LRP5/6 cytoplasmic domain by CSNKI'�

@goodb goodb closed this as completed Sep 10, 2018
@deustp01
Copy link
Collaborator

deustp01 commented Dec 9, 2018

This looks like a legacy problem that Reactome has now fixed. It used to be legal to annotate regulation of an entity. We decided that wasn't useful, removed all such annotations, and changed the curation process so no more can be made. However, depending when the BioPax used here was generated, it might have included some old regulation_of_entity instances.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants