Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add contributed_by statements as Reactome wants them #38

Closed
goodb opened this issue Dec 19, 2018 · 12 comments
Closed

add contributed_by statements as Reactome wants them #38

goodb opened this issue Dec 19, 2018 · 12 comments
Assignees

Comments

@goodb
Copy link
Contributor

goodb commented Dec 19, 2018

This is pending decisions about what Reactome curators to see here.

@goodb goodb self-assigned this Dec 19, 2018
@goodb
Copy link
Contributor Author

goodb commented Jan 8, 2019

@deustp01 let me know what you would like to see here when you all decide. (Note that whatever you want to see ought to be represented in the BioPAX export somehow.)

@goodb
Copy link
Contributor Author

goodb commented Jan 17, 2019

@deustp01 a gentle ping on status? Would love to incorporate this update into the next batch conversion.

@deustp01
Copy link
Collaborator

Sorry! Anyone worked on an item as a curator, editor, or reviewer should be credited but these specific roles don't matter. So if you can grab the names associated with the "created", "edited", and "reviewed" attributes of the pathway that is being converted and then uniquify the list (if the same person had more than one role, only one mention is needed) that should work. Some very old pathways may lack associated person names, because we weren't using these attributes consistently at the start of the project. In those cases, the information has been lost so, if this doesnb't break anything on your end, no one gets credit.

@goodb
Copy link
Contributor Author

goodb commented Jan 17, 2019

Right now we are using http://purl.org/dc/elements/1.1/contributor to link models to contributors. It doesn't officially require a URL, but our software generally expects one. e.g. orcid ids like http://orcid.org/0000-0003-3641-7548 . As it stands, I can mine comments for strings like: "Edited: Shamovsky, V, 2010-02-27" but it would be much better in the long term if your team could replace those with orcids. Let me know if there are any plans to make a change like that. If not, I will go ahead and add the names as Strings and see what happens.

@goodb
Copy link
Contributor Author

goodb commented Jan 17, 2019

In fact, at the pathway level, these comments are already there in the models, you just can't see them in Noctua. (You can see them in Protege if you look at the model that way). e.g.
screen shot 2019-01-17 at 3 57 18 pm

@ukemi
Copy link

ukemi commented Jan 18, 2019

@goodb
Are you going to recalculate the models. I have been working on the one that is linked from the document.

@goodb
Copy link
Contributor Author

goodb commented Jan 18, 2019 via email

@ukemi
Copy link

ukemi commented Jan 18, 2019

I can't seem to save the current model under a different name.

@goodb
Copy link
Contributor Author

goodb commented Jan 18, 2019 via email

@ukemi
Copy link

ukemi commented Jan 18, 2019

Thanks @goodb. I'm seeing some pretty consistent things that I think can be codified wrt limiting models.

@goodb
Copy link
Contributor Author

goodb commented Aug 12, 2019

@deustp01 I believe we are okay to close this, yes?

Each model refers to the original source in Reactome which carries the complete attribution data. In addition, the root pathway node for each model brings over the text for the pathway editor, reviewers, etc.

When reactome updates its own internal attribution model and this is made available in the BioPAX lets open a new ticket to enhance the models as appropriate.

@deustp01
Copy link
Collaborator

OK to close.

@goodb goodb closed this as completed Aug 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants