-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add contributed_by statements as Reactome wants them #38
Comments
@deustp01 let me know what you would like to see here when you all decide. (Note that whatever you want to see ought to be represented in the BioPAX export somehow.) |
@deustp01 a gentle ping on status? Would love to incorporate this update into the next batch conversion. |
Sorry! Anyone worked on an item as a curator, editor, or reviewer should be credited but these specific roles don't matter. So if you can grab the names associated with the "created", "edited", and "reviewed" attributes of the pathway that is being converted and then uniquify the list (if the same person had more than one role, only one mention is needed) that should work. Some very old pathways may lack associated person names, because we weren't using these attributes consistently at the start of the project. In those cases, the information has been lost so, if this doesnb't break anything on your end, no one gets credit. |
Right now we are using http://purl.org/dc/elements/1.1/contributor to link models to contributors. It doesn't officially require a URL, but our software generally expects one. e.g. orcid ids like http://orcid.org/0000-0003-3641-7548 . As it stands, I can mine comments for strings like: "Edited: Shamovsky, V, 2010-02-27" but it would be much better in the long term if your team could replace those with orcids. Let me know if there are any plans to make a change like that. If not, I will go ahead and add the names as Strings and see what happens. |
@goodb |
Yes, there are a lot of improvements I want to push. If you want to preserve any of your changes you will want to save them somewhere else either as a model with a different name or as a new model in main noctua. noctua-dev is not a stable collection.
… On Jan 17, 2019, at 4:03 PM, David Hill ***@***.***> wrote:
@goodb
Are you going to recalculate the models. I have been working on the one that is linked from the document.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.
|
I can't seem to save the current model under a different name. |
Okay I won’t reload the models until I’ve found a way to preserve this one. One way is to save the OWL out as a file and then commit it under a new name. That will work but won’t be available until the next update.
… On Jan 18, 2019, at 6:20 AM, David Hill ***@***.***> wrote:
I can't seem to save the current model under a different name.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.
|
Thanks @goodb. I'm seeing some pretty consistent things that I think can be codified wrt limiting models. |
@deustp01 I believe we are okay to close this, yes? Each model refers to the original source in Reactome which carries the complete attribution data. In addition, the root pathway node for each model brings over the text for the pathway editor, reviewers, etc. When reactome updates its own internal attribution model and this is made available in the BioPAX lets open a new ticket to enhance the models as appropriate. |
OK to close. |
This is pending decisions about what Reactome curators to see here.
The text was updated successfully, but these errors were encountered: