Skip to content

Commit

Permalink
Fix go vet err and remove unit from concourse pipeline.
Browse files Browse the repository at this point in the history
  • Loading branch information
genevieve committed May 10, 2023
1 parent d651b68 commit 6a8d1cd
Show file tree
Hide file tree
Showing 6 changed files with 3 additions and 54 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -40,4 +40,4 @@ jobs:
run: go vet ./...

- name: Run unit tests
run: ginkgo -r .
run: ginkgo -p -r -race -randomizeAllSpecs -randomizeSuites .
3 changes: 2 additions & 1 deletion acceptance/vsphere.go
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,8 @@ func NewVSphereAcceptance() VSphereAcceptance {

vCenterUrl.User = url.UserPassword(vcenterUser, vcenterPassword)

vContext, _ := context.WithTimeout(context.Background(), time.Minute*5)
vContext, cancel := context.WithTimeout(context.Background(), time.Minute*5)
defer cancel()

vimClient, err := govmomi.NewClient(vContext, vCenterUrl, true)
Expect(err).NotTo(HaveOccurred())
Expand Down
14 changes: 0 additions & 14 deletions ci/pipeline.yml
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
groups:
- name: leftovers
jobs:
- unit
- acceptance-aws
- acceptance-azure
- acceptance-gcp
Expand Down Expand Up @@ -33,20 +32,11 @@ resources:
private_key: ((tap_private_key))

jobs:
- name: unit
serial: true
plan:
- get: leftovers
trigger: true
- task: unit
file: leftovers/ci/tasks/unit/task.yml

- name: acceptance-gcp
serial: true
plan:
- get: leftovers
trigger: true
passed: [unit]
- task: acceptance
file: leftovers/ci/tasks/acceptance/task.yml
params:
Expand All @@ -58,7 +48,6 @@ jobs:
plan:
- get: leftovers
trigger: true
passed: [unit]
- task: acceptance
file: leftovers/ci/tasks/acceptance/task.yml
params:
Expand All @@ -72,7 +61,6 @@ jobs:
plan:
- get: leftovers
trigger: true
passed: [unit]
- task: acceptance
file: leftovers/ci/tasks/acceptance/task.yml
params:
Expand All @@ -87,7 +75,6 @@ jobs:
plan:
- get: leftovers
trigger: true
passed: [unit]
- task: acceptance
file: leftovers/ci/tasks/acceptance/task.yml
tags:
Expand All @@ -107,7 +94,6 @@ jobs:
plan:
- get: leftovers
trigger: true
passed: [unit]
- task: acceptance
file: leftovers/ci/tasks/acceptance/task.yml
params:
Expand Down
10 changes: 0 additions & 10 deletions ci/tasks/unit/task

This file was deleted.

13 changes: 0 additions & 13 deletions ci/tasks/unit/task.yml

This file was deleted.

15 changes: 0 additions & 15 deletions scripts/test

This file was deleted.

0 comments on commit 6a8d1cd

Please sign in to comment.