-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update API and add performance enhancements to CollectionTables #229
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have few comments. Also, make sure that tests pass.
6737fe9
to
73e798a
Compare
@JureZmrzlikar Can you look at Jenkins and help me understand why it is failing? |
I have no clue. @acopar Do you have any idea? |
This problem happened because pip switched the default dependency resolver on the recent 20.3.* version. The new resolver has different dependency resolution, and causes some glitches with dependencies, in particular backtracking package versions until timeout. This PR should fix this problem: We can re-trigger build after genialis-base PR is merged. |
What is the status? Can we merge this PR? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just have few comments. Otherwise looks good to me.
73e798a
to
1196e38
Compare
Codecov Report
@@ Coverage Diff @@
## master #229 +/- ##
==========================================
+ Coverage 80.72% 80.92% +0.20%
==========================================
Files 27 27
Lines 1619 1636 +17
==========================================
+ Hits 1307 1324 +17
Misses 312 312
Continue to review full report at Codecov.
|
1196e38
to
aa64587
Compare
What started with just a few fixes ended up being closer to a rewrite.
The major changes are:
metadata()
->meta
,expressions()
->exp
,counts()
->rc
clear_cache()
which removes all cache files from the default locationid_to_symbol
which holds gene id to symbole mappingexp
andrc
return gene ids instead of symbolesCollectionTable
toresdk
namespaceattrs['exp_type']
attributePerformance on 45 samples (
exp
andrc
have the same performance):* calling just one of
metadata()
orexpressions()
, if used together resolwe server gets queried only once and performance improves for he second function for ~120s** without gene id to symbol mapping