Handle unexpected errors and print the error message #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #5 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 1 1
Lines 144 151 +7
=====================================
+ Hits 144 151 +7
Continue to review full report at Codecov.
|
dblenkus
force-pushed
the
feature-unexpectederrors
branch
from
43871b2
to
8bdcfb5
Compare
dblenkus
force-pushed
the
feature-unexpectederrors
branch
3 times, most recently
from
2aebd6f
to
33a8609
Compare
tjanez
approved these changes
Aug 8, 2017
docs/CHANGELOG.rst
Outdated
| @@ -12,8 +12,9 @@ Unreleased | |||
|
|
|||
| Changed | |||
| ------- | |||
| - Unexpected errors in ``re-*`` functions are handled and error with | |||
| - Unexpected errors in ``re-*`` functions are handled and error with | |||
There was a problem hiding this comment.
Move this change to the previous commit (where it belongs).
docs/CHANGELOG.rst
Outdated
|
|
||
| Changed | ||
| ------- | ||
| - Unexpected errors in ``re-*`` functions are handled and error with |
There was a problem hiding this comment.
I would change the sentence to imperative mode, something like:
Handle unexpected errors in re-* functions and print an error with a descriptive message
dblenkus
force-pushed
the
feature-unexpectederrors
branch
from
33a8609
to
4ee3f95
Compare
dblenkus
force-pushed
the
feature-unexpectederrors
branch
from
4ee3f95
to
bcf0606
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.