remove temporary directory if it is empty and check if the xml file was copied from the device #389
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…file method check if the xml (intermediate) file was copied from the external device or not fix genicam#358
|
@sunavlis Hi Silvan, thank you for the PR and the message you sent to me offline. I will reply to the message in the following days. Regards, Kazunari. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request deletes the temporary created directory used for the intermediate files (XML files) loaded via register map.
It checks if the directory is empty and deletes only an empty directory.
Additional it checks if the XML file was loaded via register map or located on the host file system. In case of a local xml file, the
_remove_intermediate_fileisn't called and the file not deleted. fix #358