-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implemented Ultraviolet sensor value #26
Conversation
…ry z-wave command in test application.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just wondering... are you using #Resharper or something? Why the underscore in front of private statics? I never understood that.
Because it's very useful - you can easily distinguish between instance fields and parameters passed to the method, especially if your methods are quite big. This style was used at both my places of work and is used by the .Net Core team, too (https://github.com/dotnet/corefx/blob/master/Documentation/coding-guidelines/coding-style.md). |
Ok I'm asking because I was adopting too this convention time go, but then I decided to drop it because modern IDEs should already tell you if the field is global or local by using different colors. |
Are you using R#? We can include .DotSettings file into the repository, so it'll be easier to synchronize code style. |
I am using Linux so R# is not available, but I think that Rider can do it anyway: |
Looks like C#6 was implemented in Mono 4.0, so I'll use the new syntax in future work. |
Hi @Bounz I've been thinking more about this _ prefixing convention and even if .Net Core team is adopting this, I don't feel like it is a wise decision. This is not needed anymore and will just create confusion and aesthetic issues in the code that was already refactored in the past. |
Ok, your repo - your rules. |
|
Implemented Ultraviolet sensor value.
Added ability to invoke arbitrary z-wave command in test application