Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

setting _max > 1 results in bad handling when removing context menu #31

Open
genius257 opened this issue Sep 4, 2022 · 0 comments
Open

setting _max > 1 results in bad handling when removing context menu #31

genius257 opened this issue Sep 4, 2022 · 0 comments
Labels
bug Something isn't working

Comments

@genius257
Copy link
Owner

Manga/www/react/components/contextMenu.tsx

Line 16 in 110c114

static _max: number = 1; //the max ammount of context menus allowed at the same time.

the issue is there is no tracking of the contextmenu instance id, when removing!

An important question is: does it make sense to show multiple context menu instances at the same time?
@genius257 genius257 added the bug Something isn't working label Sep 4, 2022
genius257 added a commit that referenced this issue Sep 4, 2022
@genius257
Removed FIXME
9d0c2ea 
it is now traced with #31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@genius257