-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: ✨ add support of stake validators #295
Conversation
Related to #294
…s information given stake address Related to #294
Related to #294
…ive details even for 404 Related to #294
…pdate of certificates and withdrawals Related to #294.
…ing logic Related to #294
…on strategy as well Related to #294
…e to better enumerate through it Related to #294
…equire for collateral in case of withdrawal/ceritificate script witness, improved privnet test now also including stake validator, modified api of `stakeAddressInfo` to now return `Nothing` in case key is not registered Related to #294
…fining it's instance for `GYStakePoolId` Related to #294
saInfos <- forM configs $ \config -> withCfgProviders config mempty $ \GYProviders {..} -> do | ||
delayBySecond | ||
gyGetStakeAddressInfo $ unsafeStakeAddressFromText "stake_test1upx0fuqcjqs4h5vp687d8j2cng4y5wkmelc6wzm5szq04qsm5d0l6" | ||
assertBool "Stake address info are not all equal" $ allEqual saInfos |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note that CI providers mashup test (which runs all of providers functions and checks for equality against different providers output) does not include local node - kupo provider but it was locally checked that gyGetStakeAddressInfo
indeed returns same value for this test case.
@@ -84,26 +90,31 @@ paymentCredentialToBech32 (GYPaymentCredentialByScript sh) = serialiseToBech32Wi | |||
-- | Stake credential. | |||
data GYStakeCredential | |||
= GYStakeCredentialByKey !GYStakeKeyHash | |||
| GYStakeCredentialByScript !GYValidatorHash | |||
| GYStakeCredentialByScript !GYStakeValidatorHash |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Though this is a breaking change but as GYStakeCredentialByScript
wasn't being made use of by any external API provided by Atlas, I assume it won't have effect for end users.
@@ -43,14 +44,18 @@ newtype GYPubKeyHash = GYPubKeyHash (Api.Hash Api.PaymentKey) | |||
deriving stock Show | |||
deriving newtype (Eq, Ord, IsString) | |||
|
|||
class CanSignTx a where | |||
class AsPubKeyHash a where |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A new class AsPubKeyHash
is introduced with essentially same members as earlier CanSignTx
. Idea is to make AsPubKeyHash
a super class of CanSignTx
since AsPubKeyHash
is useful for other credentials which do not have any relation with signing such as GYStakePoolId
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed.
Related to #294
Seeing the upcoming integration with clb, full support for plutus-simple-model is not yet implemented. We can mention this gotcha in Atlas's documentation.