Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add FindXxx.cmake files to api archives #5087

Closed
jschlatow opened this issue Jan 5, 2024 · 4 comments
Closed

add FindXxx.cmake files to api archives #5087

jschlatow opened this issue Jan 5, 2024 · 4 comments

Comments

@jschlatow
Copy link
Member

As discussed in genodelabs/goa#52, the cmake-support for Goa requires certain FindXxx.cmake files. Instead of hosting these files statically in the Goa tree (thereby making all libraries available by default), I'd rather like to add these to the related api archives. This way, the Goa user gets correct hints from cmake w.r.t. what archives need to be added to the used_apis file.

jschlatow added a commit to jschlatow/genode that referenced this issue Jan 5, 2024
The FindXxx.cmake files are used by Goa's cmake support.

genodelabs#5087
@jschlatow
Copy link
Member Author

Commit 32975a4 adds those FindXxx.cmake files that have been so far identified by @cnuke, @ssumpf and myself. I will create a separate issue for api/sdl2 in genode-world.

@cnuke, @ssumpf: May you try the modified api archives (available in my depot as version 2024-01-05) with your yquake2 resp. dhewm3 port and the current goa staging branch? The corresponding sdl2 archives are available on my depot as version 2023-12-15-b.

@ssumpf
Copy link
Member

ssumpf commented Jan 5, 2024

@jschlatow: I will need to move the dhewm3 project to a current version of Goa in the first place, which with the new SDL2 improvements should be possible. Also dhewm3 requires OpenAL. So I still have some work to do before I can test this, but I put it on my TODO list.

@cnuke
Copy link
Member

cnuke commented Jan 8, 2024

@jschlatow thanks, works fine with my projects 👍.

chelmuth pushed a commit that referenced this issue Jan 15, 2024
The FindXxx.cmake files are used by Goa's cmake support.

#5087
chelmuth pushed a commit that referenced this issue Feb 26, 2024
The FindXxx.cmake files are used by Goa's cmake support.

#5087
@nfeske
Copy link
Member

nfeske commented Feb 29, 2024

Merged in master.

@nfeske nfeske closed this as completed Feb 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants