Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pc_nic_drv: 'kvfree_call_rcu' not implemented #5089

Closed
cproc opened this issue Jan 8, 2024 · 4 comments
Closed

pc_nic_drv: 'kvfree_call_rcu' not implemented #5089

cproc opened this issue Jan 8, 2024 · 4 comments
Assignees

Comments

@cproc
Copy link
Member

cproc commented Jan 8, 2024

When I tried to run Sculpt on a PC with an ASUS Q170T main board, which has both an Intel and a Realtek NIC, the following error occured:

[init -> runtime -> nic_drv] NR_IRQS: 4352, nr_irqs: 4352, preallocated irqs: 256
[init -> runtime -> nic_drv] time-clocksource: dde_counter: mask: 0xffffffffffffff max_cycles: 0x1d854df40, max_idle_ns: 3526361616960 ns
[init -> runtime -> nic_drv] time-clocksource: jiffies: mask: 0xffffffff max_cycles: 0xffffffff, max_idle_ns: 7645041785100000 ns
[init -> runtime -> nic_drv] time-clocksource: Switched to clocksource dde_counter
[init -> runtime -> nic_drv] e1000-e1000_main: Intel(R) PRO/1000 Network Driver
[init -> runtime -> nic_drv] e1000-e1000_main: Copyright (c) 1999-2006 Intel Corporation.
[init -> runtime -> nic_drv] e1000e-netdev: Intel(R) PRO/1000 Network Driver
[init -> runtime -> nic_drv] e1000e-netdev: Copyright(c) 1999 - 2015 Intel Corporation.
[init -> runtime -> nic_drv] e1000e 00:1f.6: Interrupt Throttling Rate (ints/sec) set to dynamic conservative mode
[init -> runtime -> nic_drv] e1000e 00:1f.6 00:1f.6 (uninitialized): Failed to initialize MSI interrupts.  Falling back to legacy interrupts.
[init -> runtime -> nic_drv] e1000e 00:1f.6 00:1f.6 (uninitialized): Reset blocked by ME
[init -> runtime -> nic_drv] e1000e 00:1f.6: PHY reset is blocked due to SOL/IDER session.
[init -> runtime -> nic_drv] e1000e 00:1f.6 eth0: (PCI Express:2.5GT/s:Width x1) 34:97:f6:db:97:5f
[init -> runtime -> nic_drv] e1000e 00:1f.6 eth0: Intel(R) PRO/1000 Network Connection
[init -> runtime -> nic_drv] e1000e 00:1f.6 eth0: MAC: 12, PHY: 12, PBA No: FFFFFF-0FF
[init -> runtime -> nic_drv] realtek-r8169_main 03:00.0: unknown chip XID d8f, contact r8169 maintainers (see MAINTAINERS file)
[init -> runtime -> nic_drv] Error: Function kvfree_call_rcu not implemented yet!
[init -> runtime -> nic_drv] Backtrace follows:
[init -> runtime -> nic_drv] backtrace "ep"
[init -> runtime -> nic_drv] Will sleep forever...
@cproc cproc added the bug label Jan 8, 2024
@cproc cproc self-assigned this Jan 8, 2024
cproc added a commit to cproc/genode that referenced this issue Jan 8, 2024
@cproc cproc changed the title nic_drv: 'kvfree_call_rcu' not implemented pc_nic_drv: 'kvfree_call_rcu' not implemented Jan 8, 2024
@cproc cproc added the fixed label Jan 8, 2024
@cproc
Copy link
Member Author

cproc commented Jan 8, 2024

Fixed by a608b1f (implementation taken from a630563).

@chelmuth
Copy link
Member

chelmuth commented Jan 9, 2024

@cproc would you mind to consolidate this implementation in dde_linux/src/lib/lx_emul/shadow/kernel/rcu/tree.c and adapt the drivers?

It may be worthwhile to comply to the conditional calculation of ptr in https://elixir.bootlin.com/linux/v6.1.71/source/kernel/rcu/tree.c#L3344

cproc added a commit to cproc/genode that referenced this issue Jan 10, 2024
@cproc
Copy link
Member Author

cproc commented Jan 10, 2024

Commit 86cbaa2 adds kvfree_call_rcu() to the lx_emul lib.

@chelmuth
Copy link
Member

Great! I merged all three commits.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants