Adding Navia #1809
Merged
Adding Navia #1809
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
RarePossum
commented
Dec 20, 2023
•
RarePossum
commented
- New character package
- Config in character package
- Run pipeline with added config
- Character key
- Shortcuts for character key
- Add Character package to imports
- Character talent stats
- Character curve
- Normal Attack
- Skill
- Burst
- A1
- A4
- C0
- C1
- C2
- C3
- C4
- C5
- C6
- Other necessary talents (custom dash/jump, low/high plunge, ...)
- Hitlag
- ICD
- StrikeType
- Hitboxes
- Attack durability
- Particles
- Frames
- Update documentation
- Update localization (IngameNames.json)
…g registered, and add skill buffs, and cons. Also fix Burst hitbox and targetting. Also Frames
…h DMG%, CR and CD buffs. Burst adjusted firerate and hitboxes
Shotgun Scaling (was divided by 5) Core ordering Minor Skill Stuff
--------- Co-authored-by: imring <vitaliyvorobets25@gmail.com>
…g registered, and add skill buffs, and cons. Also fix Burst hitbox and targetting. Also Frames
Fixed Normal Attack Hitboxes Fixed Burst Artillery Timings Fixed Surging blade being a callback Adjusted for New Crystallise mechanism
k0l11
reviewed
Dec 23, 2023
|
Missing documentation.
|
k0l11
reviewed
Dec 23, 2023
|
actually missing localization as well |
|
Also pls install VS Code/fix the linting errors somehow |
k0l11
reviewed
Dec 24, 2023
k0l11
reviewed
Dec 24, 2023
k0l11
approved these changes
Dec 24, 2023
thom7195
pushed a commit
to thom7195/gcsim
that referenced
this pull request
Feb 19, 2024
* Navia Initial Commit. Todo, fix SurgingBlade() and SkillCB() not being registered, and add skill buffs, and cons. Also fix Burst hitbox and targetting. Also Frames * Fixed Stackoverflow from lack of Init, added CDs for Skill, along with DMG%, CR and CD buffs. Burst adjusted firerate and hitboxes * Fixed All Burst hits granting Shrapnel Shotgun Scaling (was divided by 5) Core ordering Minor Skill Stuff * Added: - Burst Status - Conditionals Fixed: - Burst Targetting - Burst Snapshot - C2 - C4 - Particle Gen - Skill ICDs * Added: - Basic Frames Fixed: - Skill AoE (still rudimentary) * Fixed: - Skill Array length * Fixed: - Character Curve * Added: - Nighttime Whispers of the Echoing Woods TODO: - Fix how the Crystallise Bonus works * Fixed: - Nighttime Whispers array error and converted to AttackMod instead of Stat mod * Fixed: - Burst and C2 Snapshotting - C2 only working with Burst up - Nighttime Whispers granting Damage% instead of Geo% - Renamed nighttimewhispers.go * Fixed: - Nighttime Whispers' 2nd Buff - Added comments * Fixed: - c4 Applying on skill instead of Burst * Update for v2 * Update for v2 * Refactored some callbacks * Neuvillette Implementation (genshinsim#1727) --------- Co-authored-by: imring <vitaliyvorobets25@gmail.com> * Navia Initial Commit. Todo, fix SurgingBlade() and SkillCB() not being registered, and add skill buffs, and cons. Also fix Burst hitbox and targetting. Also Frames * Reverted some things I missed when rebasing * Fixed Keys * Removed nighttimewhispers.go * Fixed missing import, and infusion timing out * Fixed shot calculation * Fixed shot calculation again * Correct Frames based on footage Fixed Normal Attack Hitboxes Fixed Burst Artillery Timings Fixed Surging blade being a callback Adjusted for New Crystallise mechanism * Added N0 timings and removed incorrect import * Fixed NA out of range error, and incorrect Skill hitboxes * Cleaned up Pull Crystal Code Slightly * Fixed Navia's Skill buffs not applying to her shotgun due to timeout * Fixed NA starting during Hold Skill * Fixed NA starting during Hold Skill * Fixed comments, updated locale, ran pipeline, added documentation, fixed pruning hitbox for skill * Fix linting, hopefully * Fix linting again, hopefully * third linting change * addressed comments, updated grammar, fixed skill, icd, updated documentation * fixed typos --------- Co-authored-by: Charlie-Zheng <Charlie-Zheng@users.noreply.github.com> Co-authored-by: imring <vitaliyvorobets25@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.