Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix sim handling enemy damage on death frame incorrectly #1910

Merged
merged 1 commit into from
Jan 20, 2024
Merged

fix sim handling enemy damage on death frame incorrectly #1910

merged 1 commit into from
Jan 20, 2024

Conversation

k0l11
Copy link
Collaborator

@k0l11 k0l11 commented Jan 20, 2024

  • should not let enemy hp become negative because in the current design applyDamage can be called again in the same frame even if the previous call killed the enemy
  • changed applyDamage to return the actual amt of dmg applied so that overkill does not count towards dps / cumulative damage dealt to the target

@k0l11
fix sim handling enemy damage on death frame incorrectly
55172ae 
- should not let enemy hp become negative because in the current design applyDamage can be called again in the same frame even if the previous call killed the enemy
- changed applyDamage to return the actual amt of dmg applied so that overkill does not count towards dps / cumulative damage dealt to the target
@k0l11 k0l11 added kind: bug Existing code is bugged area: pkg Related to core logic labels Jan 20, 2024
@k0l11 k0l11 merged commit 3bf7587 into genshinsim:main Jan 20, 2024
3 checks passed
@k0l11 k0l11 deleted the fix-enemy-hp-overkill branch January 20, 2024 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@unleashurgeek unleashurgeek unleashurgeek approved these changes

Assignees
No one assigned
Labels
area: pkg Related to core logic kind: bug Existing code is bugged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@k0l11 @unleashurgeek