Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/makefile #7

Closed
wants to merge 2 commits into from
Closed

Fix/makefile #7

wants to merge 2 commits into from

Conversation

bor
Copy link
Collaborator

@bor bor commented Aug 15, 2014

No description provided.

@bor
add NO_META & NO_MYMETA options
55020d8 
NO_META suppresses the generation and addition to the MANIFEST of the
  META.yml and META.json module meta-data files during 'make distdir'
NO_MYMETA suppresses the generation of MYMETA.yml and MYMETA.json
  module meta-data files during 'perl Makefile.PL'
@bor
remove META.yml - it's the old and useless
e1c8fa6 
META.yml is usable only for cpan, but we do not upload to it
@kentfredric
Copy link
Member

Prohibiting the generation of MYMETA is probably a bug. Those files are generated standard to communicate cross-development things on CPAN. Granted, g-cpan is not on cpan, so it may be a moot point.

But usually, the need to disable this generation indicates you're doing something wrong.

Same goes for META.yml, it should be generated by EUMM during 'make dist', as should META.json.

@bor
Copy link
Collaborator Author

bor commented Aug 18, 2014

The main reason why I suggest the change is 'we do not promote g-cpan to CPAN'.
If you think the reason is not enough - ok I'll decline the request :)
But META.yml should be removed at least. As you notice already - it is generated by 'make dist'.

Questions:

  1. Is there any plan to promote g-cpan to CPAN? (like App-gcpan for example)
  2. How the dist is generated? 'make dist' or another method?

@kentfredric
Copy link
Member

The main reason why I suggest the change is 'we do not promote g-cpan to CPAN'.

Well, I guess, g-cpan is a bit horrible in terms of quality. Though it could be shipped to CPAN and we could deploy to gentoo the same way we do all the other things.

But META.yml should be removed at least. As you notice already - it is generated by 'make dist'.

Yeh, it should be in .gitignore I think, and generated from Makefile.PL by whoever is shipping it.
As should MANIFEST, as that really shouldn't be committed either.

Workflow is

  1. Check out code
  2. Run perl Makefile.PL
  3. Run make manifest
  4. Run make dist

And you'll note that the resulting tar contains a META.yml, and a MANIFEST that describes META.yml =).

So there is no reason to have any of:

  • MANIFEST
  • META.yml
  • META.json

committed in the tree at all.

@bor
Copy link
Collaborator Author

bor commented Aug 18, 2014

Thank you for complete response.
It seems like as I thought :)
So I'll create another pull request for that.

@bor bor closed this Aug 18, 2014
@bor bor mentioned this pull request Aug 20, 2014
Closed
bor added a commit to bor/g-cpan that referenced this pull request Aug 20, 2014
@bor
remove META.yml
7bfa7fe 
the currect version is old and it should be generated by 'make dist'
see issues gentoo-perl#7 & gentoo-perl#8
@bor bor deleted the fix/makefile branch October 6, 2015 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bor @kentfredric