Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes a problem with the replacement of the icu4j library #5

Conversation

stefan-langenmaier
Copy link
Contributor

I have a fresh Gentoo installation and the Eclipse installation went without an error.
When I started Eclipse I got the popup that said an error occurred and I should check the log.

I fixed my install by changing the line for the icu4j bundle.
After a reinstallation Eclipse starts.

@hartwork
Copy link
Member

Hello @stefan-langenmaier,

the trailing log4j-1.2.8.jar is mistaken of course, but should not have been a problem since the function it is passed to does not make used of a fifth parameter. Fixed in 8562b03.

Before changing "icu4j-52" to "icu4j:52" I would like to understand what the error is. For me, "icu4j-52" works fine and since that parameter is the Java package name, I would expect it to be "icu4j-52". So one way or another there is something to learn here. Please help me understand what's going on.

@stefan-langenmaier
Copy link
Contributor Author

Hello @hartwork ,

yes I thought as well that the the log4j-1.2.8.jar parameter will be ignored.

For the other change I hoped that you could enlighten me. :)
But I can tell you how I understand the function java-pkg_jar-from. The second parameter is the package. I thought you wanted to specify the slot 52 and not the version 52 (because in the DEPEND section I saw >=dev-java/icu4j-54.1.1:52). I added the quotes because of the colon. I'm never sure how it's interpreted in bash files.
I have no idea, why it works for you and not for me or why there is no error on my side while installing it as I only have the version 54 installed.

@stefan-langenmaier
Copy link
Contributor Author

Hello again @hartwork ,

I really love that Gentoo finally made the switch to git. Do you know a place to leave the devs a big "Thank you" message?

@hartwork
Copy link
Member

I really love that Gentoo finally made the switch to git. Do you know a place to leave the devs a big "Thank you" message?

The gentoo-dev mailing list would be a good place, I suppose.

I have version 54 installed too, the Java package is named "icu4j-52" nevertheless, hence the same slot:

# qlist dev-java/icu4j
/usr/share/icu4j-52/lib/icu4j.jar
/usr/share/icu4j-52/lib/icu4j-charset.jar
/usr/share/icu4j-52/lib/icu4j-localespi.jar
/usr/share/icu4j-52/package.env
                ^^^
/usr/share/doc/icu4j-54.1.1/html/readme.html
                    ^^^

Could you try re-emerging eclipse-sdk-bin and share the ICU error from the log if any? Can the ticket be closed?

@stefan-langenmaier
Copy link
Contributor Author

Thanks.

I'm at the moment at another machine but when I do the installation I have the same error even though my output for the package is the same.

# qlist dev-java/icu4j
/usr/share/doc/icu4j-54.1.1/html/readme.html
/usr/share/icu4j-52/package.env
/usr/share/icu4j-52/lib/icu4j-localespi.jar
/usr/share/icu4j-52/lib/icu4j-charset.jar
/usr/share/icu4j-52/lib/icu4j.jar

I cannot add the eclipse error log because I don't have the permission to and it's too big to paste it in here completely so I pasted only the beginning of the log but the other errors are very similar.

!SESSION 2015-10-25 13:05:43.493 -----------------------------------------------
eclipse.buildId=4.5.0.I20150603-2000
java.version=1.7.0_85
java.vendor=Oracle Corporation
BootLoader constants: OS=linux, ARCH=x86_64, WS=gtk, NL=en_US
Framework arguments:  -product org.eclipse.epp.package.java.product 
Command-line arguments:  -os linux -ws gtk -arch x86_64 -product org.eclipse.epp.package.java.product 

!ENTRY org.eclipse.ant.launching 4 0 2015-10-25 13:05:49.300
!MESSAGE FrameworkEvent ERROR
!STACK 0
org.osgi.framework.BundleException: Could not resolve module: org.eclipse.ant.launching [56]
  Unresolved requirement: Import-Package: com.ibm.icu.text

    at org.eclipse.osgi.container.Module.start(Module.java:434)
    at org.eclipse.osgi.container.ModuleContainer$ContainerStartLevel.incStartLevel(ModuleContainer.java:1582)
    at org.eclipse.osgi.container.ModuleContainer$ContainerStartLevel.incStartLevel(ModuleContainer.java:1561)
    at org.eclipse.osgi.container.ModuleContainer$ContainerStartLevel.doContainerStartLevel(ModuleContainer.java:1533)
    at org.eclipse.osgi.container.ModuleContainer$ContainerStartLevel.dispatchEvent(ModuleContainer.java:1476)
    at org.eclipse.osgi.container.ModuleContainer$ContainerStartLevel.dispatchEvent(ModuleContainer.java:1)
    at org.eclipse.osgi.framework.eventmgr.EventManager.dispatchEvent(EventManager.java:230)
    at org.eclipse.osgi.framework.eventmgr.EventManager$EventThread.run(EventManager.java:340)

!ENTRY org.eclipse.ant.ui 4 0 2015-10-25 13:05:49.311
!MESSAGE FrameworkEvent ERROR
!STACK 0
org.osgi.framework.BundleException: Could not resolve module: org.eclipse.ant.ui [57]
  Unresolved requirement: Import-Package: com.ibm.icu.text

    at org.eclipse.osgi.container.Module.start(Module.java:434)
    at org.eclipse.osgi.container.ModuleContainer$ContainerStartLevel.incStartLevel(ModuleContainer.java:1582)
    at org.eclipse.osgi.container.ModuleContainer$ContainerStartLevel.incStartLevel(ModuleContainer.java:1561)
    at org.eclipse.osgi.container.ModuleContainer$ContainerStartLevel.doContainerStartLevel(ModuleContainer.java:1533)
    at org.eclipse.osgi.container.ModuleContainer$ContainerStartLevel.dispatchEvent(ModuleContainer.java:1476)
    at org.eclipse.osgi.container.ModuleContainer$ContainerStartLevel.dispatchEvent(ModuleContainer.java:1)
    at org.eclipse.osgi.framework.eventmgr.EventManager.dispatchEvent(EventManager.java:230)
    at org.eclipse.osgi.framework.eventmgr.EventManager$EventThread.run(EventManager.java:340)

!ENTRY org.eclipse.compare 4 0 2015-10-25 13:05:49.320
!MESSAGE FrameworkEvent ERROR
!STACK 0
org.osgi.framework.BundleException: Could not resolve module: org.eclipse.compare [58]
  Unresolved requirement: Import-Package: com.ibm.icu.util

    at org.eclipse.osgi.container.Module.start(Module.java:434)
    at org.eclipse.osgi.container.ModuleContainer$ContainerStartLevel.incStartLevel(ModuleContainer.java:1582)
    at org.eclipse.osgi.container.ModuleContainer$ContainerStartLevel.incStartLevel(ModuleContainer.java:1561)
    at org.eclipse.osgi.container.ModuleContainer$ContainerStartLevel.doContainerStartLevel(ModuleContainer.java:1533)
    at org.eclipse.osgi.container.ModuleContainer$ContainerStartLevel.dispatchEvent(ModuleContainer.java:1476)
    at org.eclipse.osgi.container.ModuleContainer$ContainerStartLevel.dispatchEvent(ModuleContainer.java:1)
    at org.eclipse.osgi.framework.eventmgr.EventManager.dispatchEvent(EventManager.java:230)
    at org.eclipse.osgi.framework.eventmgr.EventManager$EventThread.run(EventManager.java:340)

!ENTRY org.eclipse.compare.core 4 0 2015-10-25 13:05:49.330
!MESSAGE FrameworkEvent ERROR
!STACK 0
org.osgi.framework.BundleException: Could not resolve module: org.eclipse.compare.core [59]
  Unresolved requirement: Import-Package: com.ibm.icu.text; version="3.6.1"

    at org.eclipse.osgi.container.Module.start(Module.java:434)
    at org.eclipse.osgi.container.ModuleContainer$ContainerStartLevel.incStartLevel(ModuleContainer.java:1582)
    at org.eclipse.osgi.container.ModuleContainer$ContainerStartLevel.incStartLevel(ModuleContainer.java:1561)
    at org.eclipse.osgi.container.ModuleContainer$ContainerStartLevel.doContainerStartLevel(ModuleContainer.java:1533)
    at org.eclipse.osgi.container.ModuleContainer$ContainerStartLevel.dispatchEvent(ModuleContainer.java:1476)
    at org.eclipse.osgi.container.ModuleContainer$ContainerStartLevel.dispatchEvent(ModuleContainer.java:1)
    at org.eclipse.osgi.framework.eventmgr.EventManager.dispatchEvent(EventManager.java:230)
    at org.eclipse.osgi.framework.eventmgr.EventManager$EventThread.run(EventManager.java:340)


@timeraider4u
Copy link
Contributor

@stefan-langenmaier: you may fork the repository, upload the file there and paste a link here. Or you may upload the log to pastebin and link to it here.

@stefan-langenmaier
Copy link
Contributor Author

Thanks, should have thought of pastebin: http://pastebin.com/vk6Ra0gP

@hartwork
Copy link
Member

I have moved to a colon with -r3 in commit 9d02686 now. Please re-verify if -r3 fixes the problem, when you have a minute. Thank you!

@stefan-langenmaier
Copy link
Contributor Author

Unfortunately the -r3 does not fix the problem. It looks like the quotes are needed. I'm now able to reproduce this issue on three different machines.

@hartwork
Copy link
Member

While ":" is the Bash intrinsic version of /bin/true, I don't see why it would need escaping and why the quotes would make any difference.

# type :
: is a shell builtin

# : ; echo $?
0

# echo one:two | od -c
0000000   o   n   e   :   t   w   o  \n
0000010

@stefan-langenmaier
Copy link
Contributor Author

This will be disappointing. Concerning the bash I have the same output as show above. Concerning Eclipse I no longer can start it. No matter if I have it installed with the quotes and the colon, just the colon or the dash. I have not done any updates on the machines since I tried to install Eclipse. (One was not even rebooted.) But I get now the same error (as shown in the log already attached) for all types of the installation.

This looks very much like an error on my side, but as I'm experiencing the problem on three machines and I have no idea how to debug this further, I'd be glad for your input.

@hartwork
Copy link
Member

If you remove that line replacing the ICU jar, does that make it start again?

@stefan-langenmaier
Copy link
Contributor Author

I commented the line. The installation works and I can start Eclipse.

I saw that you also modified the line for commons-httpclient. I tried it with the dash and the colon. Both versions work.

@hartwork
Copy link
Member

Sounds like ICU should not be unbundled for you right now. I have made 4.5.0-r4 do that with commit 7bc62c5. I'll close this ticket. Please re-open as needed.

Best, Sebastian

@hartwork hartwork closed this Oct 31, 2015
@stefan-langenmaier
Copy link
Contributor Author

You can keep it closed. The current ebuild is working for me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants