-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix modinfo error #57
Conversation
reagentoo
commented
Feb 2, 2024
•
edited
Loading
edited
…t modinfo error Also improved gen_dep_list() and get rid xbasename() Bug: https://bugs.gentoo.org/922663 Closes: gentoo#57 Signed-off-by: Dmitry Baranov <reagentoo@gmail.com>
ea9b7a1
to
6b192ab
Compare
Tested this PR and the use case from #54 seems okay, as long as With |
I also don't like that @mgorny Can you please suggest? |
I had compressed firmware ( |
I understood you. But I think you correctly pointed out earlier that this is a separate fix for future PRs. |
I think that supporting compressed modules and firmware in genkernel would make a lot of sense, considering it's only a matter of wildcard matching |
…t modinfo error Also improved gen_dep_list() and get rid xbasename() Bug: https://bugs.gentoo.org/922663 Closes: gentoo#57 Signed-off-by: Dmitriy Baranov <reagentoo@gmail.com>
…t modinfo error Also improved gen_dep_list() and get rid xbasename() Bug: https://bugs.gentoo.org/922663 Closes: gentoo#57 Signed-off-by: Dmitriy Baranov <reagentoo@gmail.com>
@FlyingWaffleDev @maciejsszmigiero Please test PR on your configurations.
|
I have tested this PR and it works fine with XZ-compressed |
@robbat2 @thesamesam Look here please. |
…FIRMWARE="no" These do not occur in the "modules.dep" file so they won't be caught by the dependency scanning loop in gen_dep_list() - they need to be manually added to the module list. Closes: gentoo#54 Signed-off-by: Maciej S. Szmigiero <mail@maciej.szmigiero.name>
…t modinfo error Also improved gen_dep_list() and get rid xbasename() Bug: https://bugs.gentoo.org/922663 Closes: gentoo#57 Signed-off-by: Dmitriy Baranov <reagentoo@gmail.com>
Signed-off-by: Dmitriy Baranov <reagentoo@gmail.com>
… size Signed-off-by: Dmitriy Baranov <reagentoo@gmail.com>
Signed-off-by: Dmitriy Baranov <reagentoo@gmail.com>
…onfig_file() This is useful for building an image with sys-kernel/gentoo-kernel. Signed-off-by: Dmitriy Baranov <reagentoo@gmail.com>
50d0c13
to
4246137
Compare
…onfig_file() This is useful for building an image with sys-kernel/gentoo-kernel. Signed-off-by: Dmitriy Baranov <reagentoo@gmail.com> Closes: #57 Signed-off-by: Ben Kohler <bkohler@gentoo.org>