Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add gnome-base/dconf-editor to the tree #3

Closed
wants to merge 1 commit into from
Closed

Add gnome-base/dconf-editor to the tree #3

wants to merge 1 commit into from

Conversation

Vindex17
Copy link
Contributor

dconf-editor has been split from dconf by upstream

@hartwork
Copy link
Member

Hi! The line

KEYWORDS="~alpha ~amd64 ~arm ~hppa ~ia64 ~mips ~ppc ~ppc64 ~sh ~sparc ~x86 ~x86-fbsd ~arm-linux ~x86-linux" 

catches my eye. Quoting Keywording new packages:

Important: New packages should be marked as ~arch only upon architectures for which the committing developer has tested.

I propose a change to ~amd64 ~x86 if you are on one of these.

Best, Sebastian

@Vindex17
Copy link
Contributor Author

I copied them from gnome-base/dconf, however I followed your suggestion, it's now ~amd64 ~x86 only

@EvaSDK
Copy link
Contributor

EvaSDK commented May 21, 2015

It is fine you copy keywords from dconf as this is a split of this package without any significant changes.
This avoid overloading arch teams.


KEYWORDS="~alpha ~amd64 ~arm ~hppa ~ia64 ~mips ~ppc ~ppc64 ~sh ~sparc ~x86 ~x86-fbsd ~arm-linux ~x86-linux"

PDEPEND="X? ( gnome-base/dconf-editor )"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This sound like a nice idea for migration but we avoid pure runtime dependencies controlled by USE flags as explained in the dev manual. We probably want to take note of this transition in a Gnome 3.16 migration guide on the Gentoo wiki.

@EvaSDK
Copy link
Contributor

EvaSDK commented May 24, 2015

Merged.

@EvaSDK EvaSDK closed this May 24, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants