app-benchmarks/unigine-superposition: new package, add 1.1

[vitaly-zdanevich]

No description provided.

[antecrescent]

A bunch of these can be caught using a simple package testing environment.

[antecrescent]

You need to add dodoc Superposition.png somewhere in src_install.

[vitaly-zdanevich]

Hm, but png is not a documentation?

[antecrescent]

Sorry, I meant to say add doicon Superposition.png in src_install :)

[vitaly-zdanevich]

Already have newicon - is it ok?

[antecrescent]

Yes, please ignore what I said earlier. Apparently, the Icon Lookup algorithm takes icons of all sizes in the hicolor fallback theme into account.
I was misled by an outdated comment in the desktop eclass.

[vitaly-zdanevich]

A bunch of these can be caught using a simple package testing environment.

Interesting that Wiki search is broken https://wiki.gentoo.org/index.php?title=Special%3ASearch&search=frecord-gcc-switches&go=Go

[ceamac]

All your commits except the first one lack a Signed-off-by line. Also they are too many :) Please squash them

[vitaly-zdanevich]

Squashed.

[antecrescent]

A few small issues, other than that it looks good from my side!

Please rebase and

1. create one commit where you add the license to ::guru and add it to the EULA group in profiles/license_groups
2. create another commit where you add the fixed package

(New licenses should be added in a separate commit before the ebuild that depends on it: https://devmanual.gentoo.org/general-concepts/licenses/index.html#adding-new-licenses)

[vitaly-zdanevich]

Done everything.

[antecrescent]

There are merge conflicts with dev. Please fetch the newest commits and rebase. Also the first commit's summary should be: licenses: add Unigine-Superposition-Benchmark-EULA

[vitaly-zdanevich]

Done.

[antecrescent]

The first commit doesn't apply cleanly, because it's not based on dev. You can use the following to properly redo your changes in an up-to-date dev branch.
Also, please refrain from creating merge commits in the future. Gentoo devs will always ask you to rebase anyways.

git fetch --all
git stash # in case there are changed files in your working tree
git reset --hard origin/dev # assuming origin is your upstream remote
git checkout 94ffb55111d025047f09c24ca1a44045e9f8dd8e -- licenses/Unigine-Superposition-Benchmark-EULA # get license from your previous commit into staging area
sed '/^EULA/s/$/ Unigine-Superposition-Benchmark-EULA/' -i profiles/license_groups # redo license_groups addition
git add profiles/license_groups
pkgdev commit -m "licenses: add Unigine-Superposition-Benchmark-EULA"
git cherry-pick a282db6e775266eb0123eefcf2169ea54488e6b6 # re-apply package addition
git push -f
git stash pop

[vitaly-zdanevich]

Wow, I did it, but still merge commits...

[antecrescent]

No more complaints from my side. I'd be glad to have another TC acknowledge the changes in this iteration before merging them.

[ceamac]

LGTM