Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sys-apps/pnpm-bin: update to 9.5.0, fix distdir and remove the -bin #216

Closed
wants to merge 2 commits into from

Conversation

groche97
Copy link
Contributor

The package is apparently abandoned, I update the binary changing this to pnpm instead of pnpm-bin in the system to be compatible with scripts, like rust-bin or other -bin packages.
When I try to update the manifest doesn't change very well because it detects the old file in distfiles, I changed the download bin in distfiles to ${P} to fix it and simplify the update process.

Copy link
Contributor

@antecrescent antecrescent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution!

Have you thought about requesting access to the server and contributing directly, yet?
That way, your changes generally get merged quicker into master and it's less work for participants overall.

@@ -0,0 +1,22 @@
# Copyright 1999-2023 Gentoo Authors
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2023-2024

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removing the old digest breaks sys-apps/pnpm-bin-9.0.6. Apply your fixes to that version in a separate commit first, please, before adding version 9.5.0.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I apply my changes to 9.0.6 and preserve the 9.5.0 (is the last stable), but if you prefer I can remove the PR and create new one only with the changes in 9.0.6

Copy link
Contributor

@antecrescent antecrescent Jul 16, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need to open a new PR, just redo the changes in the correct order and force-push e.g.

git reset --hard HEAD~2
pushd sys-apps/pnpm-bin
sed -e 's/1999-2023/2023-2024/' -e '/^SRC_URI/s/"$/ -> ${P}"/' \
-e 's/${PN}/pnpm/' -e '/newbin/s/pnpm-linux-x64/${P}/' \
-i pnpm-bin-9.0.6.ebuild
sed 's/pnpm-linux-x64/pnpm-bin-9.0.6/' -i Manifest
git add pnpm-bin-9.0.6.ebuild
pkgdev commit -e # edit the commit message to reflect your changes
cp pnpm-bin-9.{0.6,5.0}.ebuild
git add pnpm-bin-9.5.0.ebuild
pkgdev manifest
pkgdev commit
popd
git push -f

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed, thanks for your patience

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks you for contributing ;) This PR will get closed automatically once e00f1d3 gets merged into master.

Signed-off-by: Guillermo Roche <groche97@gmail.com>
Signed-off-by: Guillermo Roche <groche97@gmail.com>
@antecrescent
Copy link
Contributor

@vitaly-zdanevich Do you still intend to maintain this package? If not, please remove yourself from metadata.xml.

@vitaly-zdanevich
Copy link
Contributor

@vitaly-zdanevich Do you still intend to maintain this package? If not, please remove yourself from metadata.xml.

I added this package because our https://complexnumbers.ru uses it, but I do not use pnpm every day..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants