fnm: add ppc64 support #90
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@darkbasic is this something you are still interested in getting merged? |
|
Yes but I have a new patch for this. |
|
@darkbasic if you update the PR with your new patch we could get this merged, if it's ready |
|
@darkbasic any update? this PR hasn't had activity for over a year. If you want to merge this, can you update the PR with the new patch and also target a version that's in tree (1.35.1 at the moment)? |
@MrRoy I've created a new PR to showcase the new approach. We managed to get ppc64 support upstream in ring 0.17, so I've simply bumped the ring version. Not sure if it's an acceptable solution though, but it works. Link to the new PR: #188 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've patched the fnm ebuild to build on ppc64le, which requires overriding the ring (indirect) dependency with a git branch containing patches. It builds fine if you don't use the cargo eclass, which downloads a tarball from github instead of cloning, leading to the same exact files except for the
.gitdirectory. Somehow without the.gitdirectory it fails to compile... It's not a matter of permissions or anything else: copying the .git directory fixes it.Log/backtrace: https://pastebin.com/cRGzVsHE
Some help would be appreciated to get rid of the workaround so that I can craft something mergeable.