Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dev-lang/rust: reimport rust-1.34.2 from smaeul's portage-overlay #276

Closed
wants to merge 2 commits into from

Conversation

stefson
Copy link
Contributor

@stefson stefson commented Oct 29, 2019

it's old, but uses the now stable llvm-8 and is suitable for building esr
more important: it doesn't suffer from a bug where cflags are bleeding
into the compile env when adding cross compile crates, this makes it a
good base for exploring these unknown waters.

I still have to open a bug on upstream github, the last clean version
is rust-1.35.0 and the first failing one is rust-1.36.0

if you're going to use with system-llvm, please check out the nifty
patchset and drop those targeting llvm into /etc/portage/patches/

…erlay/

it's old, but uses the now stable llvm-8 and is suitable for building esr
more important: it doesn't suffer from a bug where cflags are bleeding
into the compile env when adding cross compile crates, this makes it a
good base for exploring these unknown waters.

if you're going to use with system-llvm, please check out the nifty
patchset and drop those targeting llvm into /etc/portage/patches/

Signed-off-by: Steffen Kuhn <nielson2@yandex.com>
@stefson stefson marked this pull request as ready for review October 30, 2019 06:16
@stefson
Copy link
Contributor Author

stefson commented Oct 30, 2019

this is good to go now, I might add an -r1 for testing cross compile crates.

Copy link
Contributor

@anarchpenguin anarchpenguin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no need to drop keywords, smauel does a fine job testing and building.

dev-lang/rust/metadata.xml Outdated Show resolved Hide resolved
@stefson
Copy link
Contributor Author

stefson commented Nov 3, 2019

@anarchpenguin like this?

dev-lang/rust/metadata.xml Outdated Show resolved Hide resolved
@anarchpenguin
Copy link
Contributor

Thanks, I will get it pushed to overlay in next few hours.

@stefson
Copy link
Contributor Author

stefson commented Nov 3, 2019

ok, I'm just going to remove the two silly little lines at the end of the metadata file.

Signed-off-by: Steffen Kuhn <nielson2@yandex.com>
@anarchpenguin
Copy link
Contributor

Sorry for the delay. I appreciate all the work you have done to help with musl.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants