Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove leftovers from {FEATURES->USE}=test removal #1129

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Remove leftovers from {FEATURES->USE}=test removal #1129

wants to merge 1 commit into from

Conversation

parona-source
Copy link
Contributor

  • FEATURES="test" was binded to USE="test" in 6b19f71, but this was effectively removed in 8c5598c.
  • This change removes mentions of this now bygone feature and unused codepaths associated with it.

@floppym
Copy link
Contributor

floppym commented Oct 15, 2023

I guess we should probably combine this change with #1116.

@parona-source
Remove leftovers from {FEATURES->USE}=test removal
b424c9a 
* FEATURES="test" was binded to USE="test" in 6b19f71, but this was
  effectively removed in 8c5598c.
* This change removes mentions of this now bygone feature and unused
  codepaths associated with it.

Signed-off-by: Alfred Wingate <parona@protonmail.com>
@parona-source
Copy link
Contributor Author

Seems reasonable. How would combining work in this case? Does this require action from me, if so what?

@floppym
Copy link
Contributor

floppym commented Oct 16, 2023

Does this require action from me, if so what?

No, I was just noting it. The changes can be merged separately.

@parona-source parona-source marked this pull request as ready for review October 16, 2023 14:47
zmedico
zmedico approved these changes Nov 14, 2023
View reviewed changes
Copy link
Member

@zmedico zmedico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zmedico zmedico zmedico approved these changes

@floppym floppym Awaiting requested review from floppym

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@parona-source @floppym @zmedico