In case ID_LIKE contains space separated identifiers #377
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hopefully this should be a straightforward fix, I am waiting for it to update my Arch user package and avoid any bad surprise in case of ID_LIKE with multiple OS names |
zmedico
reviewed
Oct 16, 2018
bin/etc-update
Outdated
| @@ -32,7 +32,7 @@ get_config() { | |||
| "${PORTAGE_CONFIGROOT}"etc/etc-update.conf) | |||
| } | |||
|
|
|||
| OS_RELEASE_POSSIBLE_IDS=$(source /etc/os-release >/dev/null 2>&1; echo ":${ID}:${ID_LIKE}:") | |||
| OS_RELEASE_POSSIBLE_IDS=$(source /etc/os-release >/dev/null 2>&1; echo ":${ID}:${ID_LIKE// /:}:") | |||
There was a problem hiding this comment.
We can use ${ID_LIKE//[[:space:]]/:} here to handle all whitespace characters (including tabs).
|
@zmedico I have implemented your proposal. |
zmedico
reviewed
Oct 19, 2018
…incl tabs) Signed-off-by: Kewl Fft <kewl@alto.eu.org> to handle all whitespace characters including tabs Signed-off-by: Kewl Fft <kewl@alto.eu.org>
|
squashed as requested |
|
Merged in 7a3d898, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per follow up discussion in #372 (comment)