Use emaint for syncing and for applying package moves #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By using emaint for syncing, EMERGE_DEFAULT_OPTS is ignored and, thus, it will not break if a user has --ask as a default option (as some do). Note that emerge --sync calls through to the emaint sync system anyway. Also, emaint provides a specific option for applying package moves so use it.
|
emaint also syncs layman repos now, so in addition to this the layman syncing step should be disabled. |
added 5 commits
August 24, 2018 01:09
The previous commit merged upstream changes while also removing support for SYNC_OVERLAYS_CMD. In this day and age, portage supports a formal repo configuration syntax and there is really no need to specify a distinct command. Instead, default to emaint sync -a, which automatically syncs all repos that have "auto-sync = yes" in effect. To account for this change, also provide a commented sample SYNC_CMD that syncs only the gentoo repo - thus, avoiding any overlays.
|
Pull request updated to address the comment from @GreatEmerald, with test support added and passed. Please review. |
|
Hi! Will need to come back later for a closer look. Could you get the merge commit out of the commit list? That would be cool. Thanks! |
|
I don't know how to do that but I'll see if I can figure it out. Otherwise, I'll do it all over and overwrite my branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By using emaint for syncing, EMERGE_DEFAULT_OPTS is ignored and, thus, it
will not break if a user has --ask as a default option (as some do). Note that
emerge --sync calls through to the emaint sync system anyway.
Also, emaint provides a specific option for applying package moves so use it in place of emerge --info.