Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unrecognized symbols cmH2O and inH2O #33

Closed
kaer opened this issue Jan 24, 2015 · 4 comments
Closed

Unrecognized symbols cmH2O and inH2O #33

kaer opened this issue Jan 24, 2015 · 4 comments
Labels
bug

Comments

@kaer
Copy link

kaer commented Jan 24, 2015

Hi, I was testing some all the units of some measurements and found some symbols that didn't work.

  • the symbols "cmH2O" and "inH2O" (pressure units) are not recognized
  • when using the grain symbol "gr" to any mass unit an incompatible unit exception is thrown
@gentooboontoo gentooboontoo mentioned this issue Jun 1, 2015
Open
@gentooboontoo gentooboontoo changed the title Unrecognized symbols Unrecognized symbols cmH2O and inH2O Jun 1, 2015
@gentooboontoo
Copy link
Owner

Internally parsed as cmH cmH O which is obviously wrong.

vsmalladi added a commit to vsmalladi/js-quantities that referenced this issue Oct 1, 2015
@vsmalladi
Updated regex to not get hung up in 2 in H2O units. gentooboontoo#33
9f69260
gentooboontoo added a commit that referenced this issue Oct 1, 2015
@gentooboontoo
Merge pull request #51 from vsmalladi/33-unrecognzied-symbols
3a18ec8 
Updated regex to not get hung up in 2 in H2O units. #33
@gentooboontoo
Copy link
Owner

Fixed by PR #51.

@matthijn
Copy link

matthijn commented Apr 27, 2016 •
edited
Loading

It seems: "when using the grain symbol "gr" to any mass unit an incompatible unit exception is thrown" is still happening.

@gentooboontoo
Copy link
Owner

A separate issue is opened (#39).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@gentooboontoo @matthijn @kaer