Adds new_with_capacity() for all other geometry types
#279
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kylebarron
reviewed
Nov 27, 2023
|
@kylebarron oops! Thanks for catching. Should be fixed. |
kylebarron
added a commit
that referenced
this pull request
Nov 28, 2023
* Public from methods on mutable arrays * optional coord type * Adds `new_with_capacity()` for all other geometry types (#279) * add multable multilinepoint array with options * new_with_options() for MultiLineString * new_with_options() for Polygon * new_with_options() for MultiPolygon * run cargo fmt * address PR comments * cargo fmt * wip public first_pass and second_pass api * Flesh out public apis --------- Co-authored-by: Josiah Parry <josiah.parry@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds
new_with_options()and their required methods for the remaining geometry types (excluding Rect).Per #276 (reply in thread)