Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

indexed geometry array #443

Merged
merged 10 commits into from
Mar 23, 2024
Merged

indexed geometry array #443

merged 10 commits into from
Mar 23, 2024

Conversation

kylebarron
Copy link
Member

@kylebarron kylebarron commented Jan 16, 2024

Change list

  • Add Indexed Geometry arrays and IndexedChunkedGeometryArray structs.
  • Implement Intersects on those structs.

@kylebarron
Copy link
Member Author

rebase after #450

@kylebarron kylebarron changed the title wip: indexed geometry array indexed geometry array Jan 20, 2024
@kylebarron
Copy link
Member Author

The most recent commit implemented intersection on indexed arrays; I still have to test it out, and I'm really curious what the perf improvement is.

I'm curious if it's possible to group more functions into a single trait so you don't have to copy the brittle two-way impls around, but some geo traits aren't uniformly implemented. Like BooleanOps right now is just implemented for polygons and multipolygons, so that couldn't exist on a trait that also serves non-polygons

@kylebarron kylebarron marked this pull request as ready for review March 23, 2024 18:04
@kylebarron kylebarron merged commit d9948af into main Mar 23, 2024
6 checks passed
@kylebarron kylebarron deleted the kyle/indexed-array branch March 23, 2024 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant