Hj/essi

[drhansj]

Passes tests on mac and Cori Haswell.

I need a little help with hdf5 flags in Makefile, config/make.osx and config/make.cori. I've checked it builds/runs with these commented out, but ideally it would just be the make flag hdf5=yes that decides that.

Please review and let me know if you need anything to finish the merge.

[andersp]

Hans, how long should it take to run the essi/M5.5....in test? I'm using 36 processors and it seems to be stuck writing the hdf5 metadata? How many procs do you use?

[drhansj]

Updated in 3953b57 with ESSI output separated into files without overlap, and timers for the ESSI output.

[andersp]

@drhansj I added another timer called "Initial data phase" to distinguish all the things that happen in "solve" before the time stepping actually starts. That way, the total time from the detailed timer matches the "executing time, time stepping phase". I then merged your hj/essi branch into developer, so you may want to remove that branch now

[drhansj]

@andersp I tried to resolve some conflicts with developer that were keeping you from merging this PR in. Please review commit 6b5c0c7 and then approve the PR?

The merge conflict I resolved was from developer into hj/essi. The files Makefile, EW.h, and make.quartz required me to manually merge, diffs here:
developer...hj/essi

[andersp]

Hans, I have already merged in your changes from hj/essi into the developer branch. Why do you want me to do this again? Anders From: Hans Johansen <notifications@github.com> Reply-To: geodynamics/sw4 <reply@reply.github.com> Date: Saturday, November 3, 2018 at 1:14 PM To: geodynamics/sw4 <sw4@noreply.github.com> Cc: Default <petersson1@llnl.gov>, Mention <mention@noreply.github.com> Subject: Re: [geodynamics/sw4] Hj/essi (#41) @andersp<https://github.com/andersp> I tried to resolve some conflicts with developer that were keeping you from merging this PR in. Please review commit 6b5c0c7<6b5c0c7> and then approve the PR? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub<#41 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AIgih-k4ajos25btIQduvvDwDZKVcmEVks5urfklgaJpZM4XLI5l>.