Avoid unhandled Delphi Exceptions crashing the DLL parent process #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielmarschall
added a commit
to danielmarschall/d7zip
that referenced
this pull request
May 13, 2024
Extended by Daniel Marschall, 13 May 2024 - geoffsmith82#8 : Fix Range Check Exception in RINOK() - geoffsmith82#9 : Avoid unhandled Delphi Exceptions crashing the DLL parent process - Implemented packing and unpacking of empty directories and hidden files (currently, no pull request sent) - Implemented restoring of the file attributes and modification times (currently, no pull request sent)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How to reproduce?
Try to 7z a folder where a file cannot be read, e.g. because it is in exclusive access by another process.
7z.dll will call the Delphi callback(s) which will throw an unhandled Delphi Exception. The DLL will raise an internal Exception 0x0eedfade which will crash the parent process (which is ironically the same Delphi process) without any possibility of recovery.
This patch changes the unhandled Delphi Exception into a HRESULT error which is correctly handled by the DLL.