partial #78 kontakt page: add IRC, Twitter, forum #130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- add bsllm - fix gmail image - review design
|
Ready to review! :) |
kumy
approved these changes
Jul 19, 2018
There was a problem hiding this comment.
FYI, only the English help page need to be updated, other languages are generated by crowdin, see
Lines 9 to 11 in 1be68fe
However, I think you commit will not be in conflict with crowdin automatic PR, you may try to keep your changes if you wish.
Else, except Codacy warning, it looks good to me. Thanks! And thanks for adding tests!
codacy catch that I dont verify generated html, this has been just fixed |
- checking html validity
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
update kontakt page:
update last help section with social groups table from konfig