simplestyleのポップアップ内でimgタグを受け付ける。 #328
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
champierre
force-pushed
the
issue-318
branch
from
07275db
to
b11abef
Compare
champierre
force-pushed
the
issue-318
branch
from
b11abef
to
b121549
Compare
keichan34
requested changes
Dec 16, 2022
| @@ -201,13 +202,12 @@ class SimpleStyleVector { | |||
| } | |||
|
|
|||
| async setPopup(map, source) { | |||
| const { default: sanitizeHtml } = await import('sanitize-html'); | |||
There was a problem hiding this comment.
ここはあえて await import しているのは、ポップアップ使っているところが少ないという仮説かつ、 sanitize-html を入れるとJSのサイズが+100kbぐらいになるということで、必要な時だけsanitize-htmlを読み込ませるように変更したんです。。他は良さそうなので sanitize-html が非同期で読み込まれるように修正いただけると助かります！ 🙇
There was a problem hiding this comment.
sanitize-html を必要なときだけ読み込むようにしました。
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
issue での要件は、ポップアップ内にひとつだけ画像を表示できるプロパティを追加することでしたが、img タグをsanitize しないタグに追加してもOKと判断し、そちらの方向で実装しました。
サニタイズをおこなう sanitize-html は、img タグの "src", "srcset", "alt", "title", "width", "height", "loading" といった attributes 以外は受け付けないというように、img タグを sanitize しないタグに追加することを想定している。
Ref. https://www.npmjs.com/package/sanitize-html
Closes #318