-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve Default Toolbar Styling #10
Comments
gm3.less will need to include the new toolbar.less for the changes to be visible. |
@theduckylittle, I noticed in the example mapbook file that the print tool has an attribute |
The mapbook has a lot of left-overs. These shouldn't be any additional |
How would you like me to link specific icons to their respective toolbar tool? If we kept the src/gm3/actions/toolbar.js:51 iconClass: toolXml.getAttribute('icon-class') src/gm3/components/toolbar.jsx:63 <span className="icon"><i className={tool.iconClass}></i></span> |
Yes, but the icon itself is not important. Styling the button is more important and the button always has an icon whether or not it's rendered (which can be determined by CSS). I think we need to just change one line of code, https://github.com/geomoose/gm3/blob/master/src/gm3/components/toolbar.jsx#L61, to something like:
I just rambled off the above, it may work, it may have a syntax error, it may light your CPU on fire. In any of those three equally likely scenarios, it adds the styling to the buttons in a way that is predictable to customize. The above code also makes the LESS pretty easy. To control the default icon:
To control a specific icon:
Happy coding. |
Related PR: #16 |
With the PR merged, I'm closing this one out. |
The "Dev Demo" lives in
./demo
. The current toolbar is pretty bland and difficult to read. A double lose!Acceptance Criteria:
src/less/toolbar.less
and use appropriate less syntax for including the icons. The catalog.less file can be used as a reference.The text was updated successfully, but these errors were encountered: