Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a "smart" layer for rendering query results. #76

Merged
merged 9 commits into from
May 26, 2017

Conversation

theduckylittle
Copy link
Member

This PR accomplishes a few things:

  1. Removes the custom filtering that I wrote to handle the grid filtering in favor of using the more feature complete mapbox "createFunction". All the necessary components have been updated to reflect that.
  2. Adds a new "transform" tag to layers so that a data type can be specified for a particular attribute. When we get to feature editing this will probably need to come up again as we'll actually want more metadata about columns than this functionality provides.
  3. The "highlight" layer has been removed in favor of an internal "results" source and layer. That "results" layer is the one that is tied to the same display as the grid. Ergo, both the grid and the layer will match when a filter is set for a query.
  4. Multiple "layers" can now be defined for a vector map-source. The first "layer" is still used to set the type name for WFS requests, however, subsequent layers can define filters and styles for the layer. This also moves <style> into instead of being a part of .
  5. A small change to z-ordering was made. A lot of the early code still assumes defaults will be set by the mapbook (this could use additional follow up work, actually) including the z-ordering. There is a change that moves automatic z-ordering assignment out of the mapbook and into the "add" action.
  6. "highlighting" now has some meta functions in application so that we can change the underlaying implementation more fluidly into the future.

1. Allows for multiple "styles" per vector source.
2. Updated the mapbook to reflect the change.
3. Moved the results layer to the top to ensure z-order goodness,
   also added a new "hot" layer for rendering hover-over styles
   with the reuslts layer.
1. Put the highlight functions into wrappers so the underlaying implementation
   can be changed into the future as is necessary.
2. There was a bug with zoom-to-extent that has now been fixed.
Conflicts:
	src/gm3/components/layers/vector.js
	src/gm3/components/map.jsx
1. Needed to clean up some linting erors.

2. Layer Z indexing now happens during msAction.add, moving it
   out of the Mapbook parser.

3. md5 is used to hash filters for easy comparison.
1. Now using createFilter to create filter functions.
2. Added new "transforms" to allow data to be forced
   to a particular format on injest. Specifically useful
   for forcing particular columns to strings or numbers.
@theduckylittle
Copy link
Member Author

Jim says "Seems to work as advertised, I'm not confident about having it full tested."

Duck says, "I have 85% confidence. The other 15% will come from use."

@theduckylittle theduckylittle merged commit 13aa05b into geomoose:master May 26, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant