-
-
Notifications
You must be signed in to change notification settings - Fork 480
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[BP] INSPIRE Validator - exception handling improvements (#7519)
Refactor of the INSPIRE Validator backend code to improve the exception handling. Previously some exceptions were not reported properly to the user. For example, if the upload of a file to validate returned an error, due to the validator not working properly (for example, returning an error 503), the user got an unclear error message. Additionally this commit contains some fixes to Sonarlint warnings
- Loading branch information
1 parent
5c185e5
commit d5d43fd
Showing
11 changed files
with
262 additions
and
172 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
26 changes: 24 additions & 2 deletions
26
...pi/records/InspireValidationRunnable.java → .../validator/InspireValidationRunnable.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
80 changes: 80 additions & 0 deletions
80
services/src/main/java/org/fao/geonet/inspire/validator/InspireValidatorException.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,80 @@ | ||
| /* | ||
| * Copyright (C) 2001-2023 Food and Agriculture Organization of the | ||
| * United Nations (FAO-UN), United Nations World Food Programme (WFP) | ||
| * and United Nations Environment Programme (UNEP) | ||
| * | ||
| * This program is free software; you can redistribute it and/or modify | ||
| * it under the terms of the GNU General Public License as published by | ||
| * the Free Software Foundation; either version 2 of the License, or (at | ||
| * your option) any later version. | ||
| * | ||
| * This program is distributed in the hope that it will be useful, but | ||
| * WITHOUT ANY WARRANTY; without even the implied warranty of | ||
| * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU | ||
| * General Public License for more details. | ||
| * | ||
| * You should have received a copy of the GNU General Public License | ||
| * along with this program; if not, write to the Free Software | ||
| * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301, USA | ||
| * | ||
| * Contact: Jeroen Ticheler - FAO - Viale delle Terme di Caracalla 2, | ||
| * Rome - Italy. email: geonetwork@osgeo.org | ||
| */ | ||
|
|
||
| package org.fao.geonet.inspire.validator; | ||
|
|
||
| import org.fao.geonet.exceptions.LocalizedException; | ||
|
|
||
| import java.util.Locale; | ||
|
|
||
| public class InspireValidatorException extends LocalizedException { | ||
| public InspireValidatorException() { | ||
| super(); | ||
| } | ||
|
|
||
| public InspireValidatorException(String message) { | ||
| super(message); | ||
| } | ||
|
|
||
| public InspireValidatorException(String message, Throwable cause) { | ||
| super(message, cause); | ||
| } | ||
|
|
||
| public InspireValidatorException(Throwable cause) { | ||
| super(cause); | ||
| } | ||
|
|
||
| protected String getResourceBundleBeanQualifier() { | ||
| return "apiMessages"; | ||
| } | ||
|
|
||
| @Override | ||
| public InspireValidatorException withMessageKey(String messageKey) { | ||
| super.withMessageKey(messageKey); | ||
| return this; | ||
| } | ||
|
|
||
| @Override | ||
| public InspireValidatorException withMessageKey(String messageKey, Object[] messageKeyArgs) { | ||
| super.withMessageKey(messageKey, messageKeyArgs); | ||
| return this; | ||
| } | ||
|
|
||
| @Override | ||
| public InspireValidatorException withDescriptionKey(String descriptionKey) { | ||
| super.withDescriptionKey(descriptionKey); | ||
| return this; | ||
| } | ||
|
|
||
| @Override | ||
| public InspireValidatorException withDescriptionKey(String descriptionKey, Object[] descriptionKeyArgs) { | ||
| super.withDescriptionKey(descriptionKey, descriptionKeyArgs); | ||
| return this; | ||
| } | ||
|
|
||
| @Override | ||
| public InspireValidatorException withLocale(Locale locale) { | ||
| super.withLocale(locale); | ||
| return this; | ||
| } | ||
| } |
Oops, something went wrong.