INSPIRE Validator - exception handling improvements and Sonalint fixes #7519
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josegar74
force-pushed
the
inspirevalidator-exceptionimprovements
branch
from
c5e695d
to
32164ad
Compare
10 tasks
fxprunayre
approved these changes
Dec 6, 2023
juanluisrp
approved these changes
Dec 7, 2023
Comment on lines
+266
to
+267
| Log.error(Log.SERVICE, | ||
| "INSPIRE service HTTP response: " + response.getStatusCode().value() + " for " + TESTOBJECTS_URL); |
There was a problem hiding this comment.
Isn't possible to log also the response body, maybe with a lower level log?
| } catch (Exception e) { | ||
| Log.error(Log.SERVICE, "Error calling INSPIRE service: " + endPoint, e); | ||
| return null; | ||
| throw new InspireValidatorException(String.format("Error calling INSPIRE service: %s, %s", endPoint, e.getMessage())); |
There was a problem hiding this comment.
I'd pass the full exception e to new InspireValidatorException() constructor to allow the logger to print Caused by: ... and get the full stacktrace.
juanluisrp
pushed a commit
that referenced
this pull request
Dec 7, 2023
Refactor of the INSPIRE Validator backend code to improve the exception handling. Previously some exceptions were not reported properly to the user. For example, if the upload of a file to validate returned an error, due to the validator not working properly (for example, returning an error 503), the user got an unclear error message. Additionally this commit contains some fixes to Sonarlint warnings
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull requests contains a refactor of the INSPIRE Validator backend code to improve the exception handling.
Previously some exceptions were not reported properly to the user. For example, if the upload of a file to validate returned an error, due to the validator not working properly (for example, returning an error 503), the user got an unclear error message:
Additionally, the pull request contains Sonarlint fixes.
Checklist
mainbranch, backports managed with labelREADME.mdfilespom.xmldependency management. Update build documentation with intended library use and library tutorials or documentation