Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Metadata inserted through CSW-T are not fully public (no download/interactive map/featured) #4156

Closed
eblondel opened this issue Oct 30, 2019 · 9 comments
Labels
Milestone

Comments

@eblondel
Copy link
Contributor

Issue Description

Metadata inserted through CSW-T are not fully public, although the CSW-T configuration Inserted metadata is public is checked (When a transation insert a new record via the CSW-T protocol, automatically publish the record to all users). The metadata can be browsed anonymously BUT it doesn't handle any link to WMS or link to download because these privileges are not enabled by default.

To Reproduce

Steps to reproduce the behavior:

  1. Go to Geonetwork config, and enable "Inserted metadata is public", save config.
  2. Insert a metadata (that includes some WMS and/or download links) using CSW-T protocol.
  3. Check the metadata privileges as logged user. (The output should be "Publish", we miss "Interactive Map" and "Download" that remain unchecked)
  4. See XML metadata as logged user (WMS/download links appear)
  5. Logout and see XML metadata as anonymous (WMS/download links are not available)

Expected behavior

Metadata inserted through CSW-T, with the CSW-T "inserted metadata is public" enabled, should be fully publicly available (published) including with "Interactive Map" & "Download" Geonetwork privileges.

Desktop

  • Browser: Chrome
  • GeoNetwork Versions tested: 3.8.1 (installed from docker official image), legacy versions tested as well using other instances: 3.0.4, 3.2.2
@eblondel eblondel changed the title Metadata inserted through CSW-T are not fully public (no download/interactive map) Metadata inserted through CSW-T are not fully public (no download/interactive map/featured) Nov 7, 2019
@PascalLike PascalLike added the bug label Nov 26, 2019
@PascalLike PascalLike added this to the 3.8.3 milestone Nov 26, 2019
@fxprunayre fxprunayre modified the milestones: 3.8.3, 3.10.2 Feb 21, 2020
@fxprunayre fxprunayre modified the milestones: 3.10.2, 3.10.3 Apr 8, 2020
@josegar74 josegar74 modified the milestones: 3.10.3, 3.10.4 Jun 25, 2020
@josegar74 josegar74 modified the milestones: 3.10.4, 3.10.5 Oct 1, 2020
@josegar74 josegar74 modified the milestones: 3.10.5, 3.10.6 Nov 6, 2020
eblondel added a commit to eblondel/core-geonetwork that referenced this issue Nov 23, 2020
@josegar74 josegar74 modified the milestones: 3.10.6, 3.12.0 Jan 15, 2021
@josegar74 josegar74 modified the milestones: 3.12.0, 3.12.1 May 7, 2021
@josegar74 josegar74 modified the milestones: 3.12.1, 3.12.2 Jul 15, 2021
@eblondel
Copy link
Contributor Author

@fxprunayre @josegar74 any blocker to merge the above code, and have it released in Geonetwork?

@fxprunayre
Copy link
Member

@fxprunayre @josegar74 any blocker to merge the above code, and have it released in Geonetwork?

Looks like it is part of 3.12 series so we can close no?
https://github.com/geonetwork/core-geonetwork/blob/3.12.x/csw-server/src/main/java/org/fao/geonet/component/csw/Transaction.java#L284-L290

@ianwallen
Copy link
Contributor

Odd that the changes are missing in the main branch?

if (metadataPublic) {
dataMan.setOperation(context, id, "" + ReservedGroup.all.getId(), ReservedOperation.view);
}

Shouldn't the changed be put into main so that it is part of the 4.x release?

@fxprunayre
Copy link
Member

@josegar74 wants to merge 3.12 in main but I think still some work required on this.

@josegar74
Copy link
Member

@fxprunayre for now we're cherry-picking specific fixes from 3.12.x to main, not doing a full merge.

But the code seem fine now in main, no?

if (metadataPublic) {
dataMan.setOperation(context, id, "" + ReservedGroup.all.getId(), ReservedOperation.view);
dataMan.setOperation(context, id, "" + ReservedGroup.all.getId(), ReservedOperation.download);
dataMan.setOperation(context, id, "" + ReservedGroup.all.getId(), ReservedOperation.dynamic);
}

@fxprunayre
Copy link
Member

But the code seem fine now in main, no?

Yep done in #5882

@eblondel
Copy link
Contributor Author

hello @fxprunayre is this solved?

@josegar74 josegar74 modified the milestones: 3.12.2, 3.12.3 Dec 14, 2021
@josegar74 josegar74 modified the milestones: 3.12.3, 3.12.4 Jan 21, 2022
@josegar74 josegar74 modified the milestones: 3.12.4, 3.12.5 Apr 11, 2022
@fxprunayre fxprunayre modified the milestones: 3.12.5, 3.12.6 Jun 13, 2022
@josegar74 josegar74 modified the milestones: 3.12.6, 3.12.7 Jun 22, 2022
@eblondel
Copy link
Contributor Author

eblondel commented Jul 5, 2022

@fxprunayre @josegar74 @juanluisrp I see this jumping from one milestone to another :-) but i don't really know if this has been integrated, and if yes since which GN version? I understand according to @fxprunayre that it has been merged into #5882
Thanks in advance

@josegar74 josegar74 modified the milestones: 3.12.7, 3.12.8 Sep 16, 2022
@josegar74 josegar74 modified the milestones: 3.12.8, 3.12.9 Dec 13, 2022
@eblondel
Copy link
Contributor Author

Ok, inspecting tags and #5882, this feature is available since 4.0.6 I'm closing the ticket. Thanks @fxprunayre for handling this in #5882

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants