Accessibility option and better responsiveness for the editor toolbar #3048
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes: - added `navbar-btn` to the buttons - simplified the display menu - changed the responsive breakpoint for the editor container - added titles and roles to the menu and menuitems
- aria labels - added `<h1>` to the page - added main landmark - added more color contrast to the toolbar
… created at' date (geonetwork#3046) * Record creation / Set title with 'Copy of' record or template title 'created at' date. This avoids to have duplicated titles, when user only create and save. * Add missing schema location. * Move properties file to core module as they are used in core and in services (eg. in StatusAction class).
|
LGTM. Michel, with your work on accessibility, maybe you should write a small mail/wiki page with a summary of common mistakes we did and things we should think about when making UI in the future? |
|
That's a good idea, I will try to find some time to write it. |
Previously a link would not be indexed if the name and description was not translated in current lang, thus preventing the fallback logic to happen (ie use values from defautl lang).
The privileges table is made more responsive, columns are now the same width, labels are hidden on small screens.
…vadoc' and redundant static [CSW REPLACE + REFACTOR] remove obsolete comment [CSW REPLACE + REFACTOR] iterator can't return null in this case [CSW REPLACE + REFACTOR] no need to set isUpdated to false in theses cases as if !isCreateMode, isUpdated will be set to true [CSW REPLACE + REFACTOR] there is a more general exception to be thrown [CSW REPLACE + REFACTOR] make nodeConfig parsing simplier [CSW REPLACE + REFACTOR] use list accessor instead of getAtIndex [CSW REPLACE + REFACTOR] get rid of vector buffer [CSW REPLACE + REFACTOR] unify list accessor [CSW REPLACE + REFACTOR] remove one indirection level [CSW REPLACE + REFACTOR] negate indirection [CSW REPLACE + REFACTOR] unify methods [CSW REPLACE + REFACTOR] refactor [CSW REPLACE + REFACTOR] rewrite debug msg [CSW REPLACE + REFACTOR] remove indirection levels [CSW REPLACE + REFACTOR] static import and indent [CSW REPLACE + REFACTOR] fix skipped test [CSW REPLACE + REFACTOR] refactor: remove code duplication [CSW REPLACE + REFACTOR] lower indirection level [CSW REPLACE + REFACTOR] remove extra loop and indirection [CSW REPLACE + REFACTOR] refactor ident [CSW REPLACE + REFACTOR] do not want last text to override content take Jose issues 2714 advice into account Allow different xml inpu targetting the same ref to operate at the same time when editing metadata.
Fixes geonetwork#2719. Only create fields `inspiretheme`, `inspirethemewithac`, `inspiretheme_en`, `inspireannex` and `inspirecat` if the element `gmd:MD_keywords` contains the `GEMET - Inspire themes, version 1.0` thesaurus.
Only index INSPIRE related fields if thesaurus is present
Proxy / do not forwards STS header
… Fix missing title for WPS2 services. (geonetwork#3032)
…t alter history when switching tabs. This means to close tab if empty history or use the redirectUrl in other cases.
…3069) When a spatial search uses the `region:` prefix and no region is found for it in the thesaurus throw an `IllegalArgumentException` with message "Geometry %s not found in the available source RegionDAO objects" instead of letting JTS try to parse a null geometry and throw the cryptic "Argument "env" should not be null." error. Also re-indent the class, organize the imports and upgrade the use of StringUtils class from Apache Commons to v3.
…eonetwork#3079) * Don't serialize the full list of category's records to XML/JSON Fixes a problem of `OutOfMemoryError` when the catalog has a lot of records with categories and the list of Groups is requested using the service `admin.group.list` since all the records asigned to each category was being returned to as part of the `records` collection. This commit excludes the records property from the XML or JSON generated. * Retrieve the category's record count using count Retrieve the number of records asigned to a category using a `count` query instead of loading all the records and counting the size of the collection returned.
When a LDAP configuration define a default privilege for a group eg. ``` ldapUserContextMapper.mapping[privilege]=privileges,eea_users ``` then on sign in, the user lost any other privileges which might have been assigned from the admin console and defaults are restored. If an LDAP user has privileges defined, preserve them and do not apply the default one. If none, add the default.
…utton Resolve behaviour of add button in editor geonetwork#3010
…typo-description update description string to match translations
…rects Map viewer - add layers with redirects (for example http -> https) doesn't work. Fixes geonetwork#3062
…-through-proxy Print map doesn't work for layers accessed through the GeoNetwork http proxy. Fixes geonetwork#3060
A new CSS class is introduced: .gn-map-item
…gistry Some thesaurus downloaded from INSPIRE registry are not stored in UTF-8 when GeoNetwork runs on Windows causing a `Error on line 1: Invalid byte 1 of 1-byte UTF-8 sequence.` Exception. This commit stores this file using UTF-8 charset.
add capability to add to map for tms protocol
This new panel only accessible by administrator user when ElasticSearch index is populated provides an overview of privileges for a set of records. This panel can be accessed from the editor board. Records can be filtered by title and publication group. User can choose which types of operation and groups to preview. This is using scripted fields in ES to create a field easily from a simple expression; here, does operation view is available for group A?
* Add support for object or nested type * Use nested type on link * Create common packages to be used by any plugins eg. 19115-3 * Add number of keyword by thesaurus
…and annexe synonym match.
Changes: - added `navbar-btn` to the buttons - simplified the display menu - changed the responsive breakpoint for the editor container - added titles and roles to the menu and menuitems
- aria labels - added `<h1>` to the page - added main landmark - added more color contrast to the toolbar
…com/MichelGabriel/core-geonetwork into master-accessibility-editor-toolbar
|
Created a new PR that replaces this one |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Several changes have been made to follow more closely the Web Accessibility standards and guidelines.
This PR focusses on the editor toolbar for logged in users.
Screenshot with the simplified display menu on the right:
Improved displaying of the editor toolbar:
navbar-btnto the buttons<button>and not a<a>)Better displaying of the buttons on small screens:
Added a11y options:
<h1>to the page