Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed bug with the profile text not being translation correctly #4774

Merged
merged 3 commits into from
Sep 29, 2020

Conversation

ianwallen
Copy link
Contributor

Administrator text was not being translated correct. Seems like it was broken several years ago...

image
image

Issue
The "Administrator" needed to be moved from the admin keys to the core keys as the text if display when not in administration area.
Also translation was being done on the text after it was lowercased so it never found the keys (this included the other keys such as editor/reviewer....). So moved the lower case option into a style.

@josegar74
Copy link
Member

@ianwallen I see you changed most of the translation files, this usually should be added only to the english files and add the translations to Transifex. Once updated there, should be updated the files with the related script in GeoNetwork.

@josegar74 josegar74 added this to the 3.10.4 milestone Jun 23, 2020
@ianwallen
Copy link
Contributor Author

ianwallen commented Jun 23, 2020

How do we "add the translations to Transifex"? I'm assuming that is something you can do?
In this case I simply moved the keys from the admin to core so I thought it would be acceptable (I was wrong). I have removed all the changes to the core.json (except for English). Are you also suggesting I only remove the key on admin.json as well and allow Transifex to remove the others?

@ianwallen
Copy link
Contributor Author

@josegar74
Are there any action items that I need to do for this request? I'm not clear on what needs to be done complete this bug fix?

@josegar74
Copy link
Member

@ianwallen, it should be kept only English versions, transifex updates the translations every day. Then requires translation in Transifex for other languages and we'll have to download the updates to GitHub using https://github.com/geonetwork/core-geonetwork/tree/master/transifex

So first step is to update the PR to keep only the English file changes and merge the PR

@ianwallen
Copy link
Contributor Author

@josegar74 - Removed all other language changes and kept English.

@ianwallen
Copy link
Contributor Author

@josegar74
You are correct that the url is not being parsed correctly. But I think it is a separate issue so I raised a new issue (#4981)

@ianwallen
Copy link
Contributor Author

@josegar74
Are there any other changes required to have this approved for the 3.10.4 release?
Thank you

@josegar74 josegar74 merged commit 1f55152 into geonetwork:master Sep 29, 2020
josegar74 pushed a commit that referenced this pull request Sep 29, 2020
…4774)

* Fixed bug with the profile text not being translation correctly

* Reverted translation on the core files as this will be done via Transifex

* Reverted translation on the admin files as this will be done via Transifex
@josegar74
Copy link
Member

@ianwallen, apologies I missed this PR, just merged and backported.

@ianwallen ianwallen deleted the fix_user_profile_translation branch August 19, 2023 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants