-
-
Notifications
You must be signed in to change notification settings - Fork 487
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed bug with the profile text not being translation correctly #4774
Fixed bug with the profile text not being translation correctly #4774
Conversation
@ianwallen I see you changed most of the translation files, this usually should be added only to the english files and add the translations to Transifex. Once updated there, should be updated the files with the related script in GeoNetwork. |
How do we "add the translations to Transifex"? I'm assuming that is something you can do? |
@josegar74 |
@ianwallen, it should be kept only English versions, transifex updates the translations every day. Then requires translation in Transifex for other languages and we'll have to download the updates to GitHub using https://github.com/geonetwork/core-geonetwork/tree/master/transifex So first step is to update the PR to keep only the English file changes and merge the PR |
@josegar74 - Removed all other language changes and kept English. |
@josegar74 |
@josegar74 |
…4774) * Fixed bug with the profile text not being translation correctly * Reverted translation on the core files as this will be done via Transifex * Reverted translation on the admin files as this will be done via Transifex
@ianwallen, apologies I missed this PR, just merged and backported. |
Administrator text was not being translated correct. Seems like it was broken several years ago...
image
Issue
The "Administrator" needed to be moved from the admin keys to the core keys as the text if display when not in administration area.
Also translation was being done on the text after it was lowercased so it never found the keys (this included the other keys such as editor/reviewer....). So moved the lower case option into a style.