Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Metadata workflow - Bulk metadata approval #5430

Merged
merged 3 commits into from
Mar 31, 2021

Conversation

josegar74
Copy link
Member

Option that allows users with Reviewer profile to approve several metadata records at once, when the metadata workflow is enabled.

menu-option

By default, only the metadata owned by the user that is in submitted status is processed. Selecting the option Approve the metadata without requiring to be in submitted status allows to approve directly the metadata without requiring to be in submitted status (similar to the option Directly approve metadata in the metadata detail page).

dialog

A report with the summary of the results is displayed when the process is finished:

report

@josegar74 josegar74 added this to the 3.12.0 milestone Feb 15, 2021
@pvgenuchten
Copy link

fixed the conflict, but now can't be rebase-merge, consider to use squash-merge

@pvgenuchten
Copy link

If one of the records is not submitted, the record will not be approved, the approve request returns a warning, but it is not displayed on screen.
image

@josegar74
Copy link
Member Author

@pvgenuchten

I have selected a metadata not in submitted status and with the option Approve, without selecting the checkbox Approve the metadata without requiring to be in submitted status. I get the following report:

approve-not-submitted

Can you recheck? Make sure the wro4j cache is cleanup.

@pvgenuchten
Copy link

when direct approve (with submit checkbox ticked) got:
image

@josegar74
Copy link
Member Author

That seem caused by an empty message in the dialog, will check to fix it.

@pvgenuchten
Copy link

Indeed, when i fill in a message, then the approval works fine!

Copy link

@pvgenuchten pvgenuchten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me (if you fix the empty message error)

@josegar74
Copy link
Member Author

@pvgenuchten updated, please try it.

Copy link

@pvgenuchten pvgenuchten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@pvgenuchten pvgenuchten merged commit b9bcca6 into geonetwork:master Mar 31, 2021
@pvgenuchten pvgenuchten deleted the bulk-metadata-approval branch March 31, 2021 09:10
@juanluisrp juanluisrp mentioned this pull request Apr 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants