Fixes some challenges in google-structured-data-test #5508
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pvgenuchten
commented
Mar 17, 2021
pvgenuchten
commented
- distribution//name,url,description are now json-escaped
- distribution//url only included if starts with http or //
- license is a creativework with name (not description)
- distribution//name,url,description are now json-escaped - distribution//url only included if starts with http or // - license is a creativework with name (not description)
fxprunayre
reviewed
Mar 17, 2021
josegar74
reviewed
Mar 17, 2021
There was a problem hiding this comment.
Tested, working fine, but please check the comment from @fxprunayre to apply the changes to iso19115-3
allow multiple dates and geo box
josegar74
approved these changes
Mar 26, 2021
josegar74
added a commit
that referenced
this pull request
Apr 1, 2021
* Fixes some challenges in google-structured-data-test - distribution//name,url,description are now json-escaped - distribution//url only included if starts with http or // - license is a creativework with name (not description) * apply license change also iso19115 allow multiple dates and geo box * Fix date elements xpath in iso19115-3.2018 jsonld formatter Co-authored-by: josegar74 <josegar74@gmail.com>
josegar74
added a commit
to GeoCat/core-geonetwork
that referenced
this pull request
Oct 12, 2021
* Fixes some challenges in google-structured-data-test - distribution//name,url,description are now json-escaped - distribution//url only included if starts with http or // - license is a creativework with name (not description) * apply license change also iso19115 allow multiple dates and geo box * Fix date elements xpath in iso19115-3.2018 jsonld formatter Co-authored-by: josegar74 <josegar74@gmail.com>
josegar74
added a commit
to GeoCat/core-geonetwork
that referenced
this pull request
Oct 12, 2021
* Fixes some challenges in google-structured-data-test - distribution//name,url,description are now json-escaped - distribution//url only included if starts with http or // - license is a creativework with name (not description) * apply license change also iso19115 allow multiple dates and geo box * Fix date elements xpath in iso19115-3.2018 jsonld formatter Co-authored-by: josegar74 <josegar74@gmail.com>
josegar74
added a commit
that referenced
this pull request
Oct 12, 2021
* Fixes some challenges in google-structured-data-test - distribution//name,url,description are now json-escaped - distribution//url only included if starts with http or // - license is a creativework with name (not description) * apply license change also iso19115 allow multiple dates and geo box * Fix date elements xpath in iso19115-3.2018 jsonld formatter Co-authored-by: josegar74 <josegar74@gmail.com> Co-authored-by: paul van genuchten <paul.vangenuchten@geocat.net>
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.