Used nv-i18n library to add better support for iso639-2/T iso639-2/B support #5982
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Will this solve the problem with the missing INSPIRE browse brick titles that contain Swedish characters? |
|
@matself This is mostly to standardize on the languages that do have different codes between T/B - i.e. fre/fra, slo/slk, der/deu... |
|
Ah well, one could always hope for a break. As a matter of fact, this is my major problem with Geonetwork right now. INSPIRE themes are an important feature.
Hälsning / Regards
Mats.E
Skickat från min / Sent from my iPad, Ursäkta att jag är kortfattad / Excuse my brevity.
… 5 okt. 2021 kl. 12:41 skrev Ian ***@***.***>:
@matself
I don't believe this will fix that problem as this fix is mostly to standardize the iso639-2/T iso639-2/B support. I see that Sweden is swe for both T and B so it should not be affected.
This is mostly to standardize on the languages that do have different codes between T/B - i.e. fre/fra, slo/slk, der/deu...
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or unsubscribe.
|
wangf1122
reviewed
Oct 5, 2021
wangf1122
approved these changes
Oct 5, 2021
josegar74
reviewed
Oct 12, 2021
core/src/main/java/org/fao/geonet/languages/IsoLanguagesMapper.java
Outdated
Show resolved
Hide resolved
| Log.error(Geonet.GEONETWORK, "Failed to get iso 2 language code for " + iso3LangCode + " caused by " + ex.getMessage()); | ||
| LanguageCode languageCode = LanguageCode.getByCode(iso3LangCode.toLowerCase()); | ||
| if (languageCode != null) { | ||
| iso2LangCode = languageCode.name(); |
There was a problem hiding this comment.
In the previous code iso2LangCode had the language 2 iso code. To confirm that this is what is returned by languageCode.name()?
services/src/main/java/org/fao/geonet/api/records/formatters/FormatterApi.java
Outdated
Show resolved
Hide resolved
…_2B should have been used. Updated language parsing to support fr:can
josegar74
approved these changes
Oct 20, 2021
|
@josegar74 |
ianwallen
added a commit
to ianwallen/core-geonetwork
that referenced
this pull request
Oct 20, 2021
Used nv-i18n library to add better support for iso639-2/T iso639-2/B support (geonetwork#5982) * Used nv-i18n library to add better support for iso639-2/T iso639-2/B support * Fixed bug where getAlpha3T and isoLanguagesMapper.iso639_2T_to_iso639_2B should have been used. Updated language parsing to support fr:can # Conflicts: # core/src/main/java/org/fao/geonet/util/XslUtil.java # pom.xml # services/src/main/java/org/fao/geonet/api/records/CatalogApi.java # services/src/main/java/org/fao/geonet/api/records/formatters/FormatterApi.java # services/src/main/java/org/fao/geonet/api/tools/i18n/LanguageUtils.java # services/src/main/java/org/fao/geonet/api/tools/i18n/TranslationApi.java
josegar74
pushed a commit
that referenced
this pull request
Oct 22, 2021
Used nv-i18n library to add better support for iso639-2/T iso639-2/B support (#5982) * Used nv-i18n library to add better support for iso639-2/T iso639-2/B support * Fixed bug where getAlpha3T and isoLanguagesMapper.iso639_2T_to_iso639_2B should have been used. Updated language parsing to support fr:can # Conflicts: # core/src/main/java/org/fao/geonet/util/XslUtil.java # pom.xml # services/src/main/java/org/fao/geonet/api/records/CatalogApi.java # services/src/main/java/org/fao/geonet/api/records/formatters/FormatterApi.java # services/src/main/java/org/fao/geonet/api/tools/i18n/LanguageUtils.java # services/src/main/java/org/fao/geonet/api/tools/i18n/TranslationApi.java
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had noticed that there were a few cases where languages were being converted from iso639-2/T iso639-2/B but there were not handling all languages. Applied a new consistent converted using the nv-i18n library.