-
-
Notifications
You must be signed in to change notification settings - Fork 487
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[a11y] Make the map and it's elements accessible #6211
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed: - map can now get the focus, so panning and zooming with the keyboard is possible - add focus outline style for the map - add focus style for the map buttons - improve focus style for location search
The main goal is to make the map accessible by keyboard. Changes: - replace popover with dropdown (popovers are added at the end of the DOM and therefore not really accessible) - rewrite the base layer selection in a plain list - reorder the map panels: the panel is now directly after the `open/close` button in the DOM - add focus to the map, this unlocks keyboard handling of the map - layerlist: more buttons are in the toolbar that is visible on hover - layerlist: button bar also visible on focus - change style popover (now a dropdown) is added to the button bar Smaller changes: - add `href` to links - more distinct `focus` state - legend panel is accessible Extra: - cleanup some css, added some basic rules - improved whitespace - removed redundant `div`s
@josegar74 thanks for reviewing. Going to fix the menus and disabled buttons. |
@josegar74 For me the menu's open to the left so they are displayed properly. Could it be cache? |
@MichelGabriel I've cleanup the wro4j cache and the browser cache and get the same: |
- left align tools on small screens - submenu in map panels now open to the left
josegar74
approved these changes
Sep 7, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested, LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main goal is to make the map accessible by keyboard.
Changes:
open/close
button in the DOMSmaller changes:
href
to links (enables focus)focus
stateExtra:
div
sSome screenshots after the changes: