API / Batch edit / Delete with a non matching XPath can remove unwanted elements #6707
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elements.
When using gn_delete tag, always consider it as an XML mode to properly
check that we are in deletion mode in EditLib.
Fix wrong test and test various type of config can be self closing tag
or not <gn_delete/> or <gn_delete></gn_delete>.
Issue was noticed using the following config
{"field":"Distribution / Remove an online resource by URL","insertMode":"gn_delete","xpath":"/gmd:MD_Metadata/gmd:distributionInfo/*/gmd:transferOptions/*/gmd:onLine[starts-with(*/gmd:linkage/gmd:URL, \"http://www.eea.europa.eu/data-and-maps/data\") or starts-with(*/gmd:linkage/gmd:URL, \"https://cmshare.eea.europa.eu/\")]","value":"","isXpath":true}
which was removing the first gmd:onLine when none were matching.
elements / Remove bad test.
josegar74
reviewed
Dec 7, 2022
core/src/test/java/org/fao/geonet/kernel/EditLibIntegrationTest.java
Outdated
Show resolved
Hide resolved
…t.java Co-authored-by: Jose García <josegar74@gmail.com>
josegar74
approved these changes
Dec 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using
gn_deletetag, always consider it as an XML mode to properly check that we are in deletion mode in EditLib.Fix wrong test and test various type of config can be self closing tag or not
<gn_delete/>or<gn_delete></gn_delete>.Issue was noticed using the following config
{"field":"Distribution / Remove an online resource by URL","insertMode":"gn_delete","xpath":"/gmd:MD_Metadata/gmd:distributionInfo/*/gmd:transferOptions/*/gmd:onLine[starts-with(*/gmd:linkage/gmd:URL, \"http://www.eea.europa.eu/data-and-maps/data\") or starts-with(*/gmd:linkage/gmd:URL, \"https://cmshare.eea.europa.eu/\")]","value":"","isXpath":true}which was removing the first
gmd:onLinewhen none were matching because it was not detecting deletion mode.