Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TST: update error message in tests for GDAL 3.9 #353

Merged

Conversation

jorisvandenbossche
Copy link
Member

Addressing test failures with GDAL main caused by OSGeo/gdal#9114.

(to be honest, being a non-native speaker, but "as being in a file format" sounds very strange to my ears)

@kylebarron
Copy link
Contributor

(to be honest, being a non-native speaker, but "as being in a file format" sounds very strange to my ears)

I think in a formal sense he's correct, but I also prefer the previous shorter, colloquial error message

@jorisvandenbossche jorisvandenbossche merged commit 84195b4 into geopandas:main Jan 27, 2024
19 checks passed
@jorisvandenbossche jorisvandenbossche deleted the fix-tests-gdal-main branch January 27, 2024 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants