Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TST: test openly accessible tiles and mark broken with status="broken" flag #78

Merged
merged 4 commits into from
Aug 8, 2021

Conversation

martinfleis
Copy link
Member

Splitting test suite into 2 files and adding tests that check all providers that do not require any API key.

I will also add a machinery marking broken sources coming from leaflet-providers and removing them from the compressed json. Just want to run CI before that to show how it behaves with broken tiles.

Some (Stadia) do not require API key according to our metadata but the domain needs to be whitelisted to make them work. Those give 403 error and are xfailed.

@martinfleis
Copy link
Member Author

As shown in CI (https://github.com/geopandas/xyzservices/pull/78/checks?check_run_id=3274570828), we have a few broken sources:

I will not remove them but add status="broken" attribute to them. That way we do not deviate from the original leaflet-providers set but clearly mark that they are broken. Since all are now reported it is likely that it will be resolved in the upstream repo.

@martinfleis martinfleis changed the title TST: test openly accessible tiles TST: test openly accessible tiles and mark broken with status="broken" flag Aug 8, 2021
@martinfleis martinfleis merged commit 33f3bc3 into geopandas:main Aug 8, 2021
@martinfleis martinfleis deleted the check_tiles branch August 8, 2021 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant