Implementation of distance on GeoSeries

[mchalecki]

• Implementation of 1:1 distance on GeoSeries
• Fix deprecated in ffi acquire_gil
• Always return python GeoSeries when using getitem
• Fix typing in test fixture

[mchalecki]

I had all precommit passed

Trim Trailing Whitespace.................................................Passed
Fix End of Files.........................................................Passed
black....................................................................Passed
isort....................................................................Passed
pyupgrade................................................................Passed
flake8...................................................................Passed

[kylebarron]

I had all precommit passed

Yeah pre-commit only runs the python lints at the moment. The rust lints are manual through cargo fmt --all (formatting) and cargo clippy --all --all-features --tests (lints). These should be documented and/or added to pre-commit but I haven't gotten to that yet

[kylebarron]

In #42 @stuartlynn put up a proposal for handling both pairwise Series-Series and broadcasted Series-Scalar function handling. In the future we'll want distance to support other being a scalar as well, but I don't think that's a blocker; it's fine to have series-series support only

[mchalecki]

In #42 @stuartlynn put up a proposal for handling both pairwise Series-Series and broadcasted Series-Scalar function handling. In the future we'll want distance to support other being a scalar as well, but I don't think that's a blocker; it's fine to have series-series support only

I agree. It didn't have an idea how to implement second behavior so i started with this implemented one in geo, the one that geopandas also uses

[mchalecki]

Can I add in black line length 120 instead of default 80?

[kylebarron]

Can I add in black line length 120 instead of default 80?

I'd prefer to stay as close as possible to the code style of upstream py-polars as possible, and they use the default of 88 I believe.

[stuartlynn]

In #42 @stuartlynn put up a proposal for handling both pairwise Series-Series and broadcasted Series-Scalar function handling. In the future we'll want distance to support other being a scalar as well, but I don't think that's a blocker; it's fine to have series-series support only

I agree. It didn't have an idea how to implement second behavior so i started with this implemented one in geo, the one that geopandas also uses

Hey @mchalecki ! Thanks for this, hoping to finish up that proposal this week and then implement it for each of the functions we already have. Will add this one to the list!