Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Start implementing geozero traits and fix offsets bugs #204

Merged
merged 6 commits into from
Jan 21, 2023
Merged

Start implementing geozero traits and fix offsets bugs #204

merged 6 commits into from
Jan 21, 2023

Conversation

kylebarron
Copy link
Member

@kylebarron kylebarron commented Jan 21, 2023 •
edited
Loading

  • Start implementing geozero::GeozeroGeometry for a couple types
  • Realized I had offsets bugs for every geometry array type when coming from geo types because try_push_usize takes the additional length as argument, not the next offset
  • Add simple round-trip tests to and from geo geometries

@kylebarron kylebarron enabled auto-merge (squash) January 21, 2023 06:34
@kylebarron kylebarron merged commit 8cfba5a into master Jan 21, 2023
@kylebarron kylebarron deleted the kyle/geozero-arrow branch January 21, 2023 06:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@kylebarron