Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to ol 6, official release #140

Merged
merged 3 commits into from
Oct 1, 2019
Merged

Update to ol 6, official release #140

merged 3 commits into from
Oct 1, 2019

Conversation

oterral
Copy link
Contributor

@oterral oterral commented Oct 1, 2019

No description provided.

@friedjoff
Copy link
Member

Nice! What about moving to the new select interaction? Is it missing any critical functionality?

@oterral
Copy link
Contributor Author

oterral commented Oct 1, 2019

@friedjoff yes they changes the way to handle the selected style. Removing the use of features overlay and apply it directly the style to the feature. When using 2 Select interactions the style are not apply properly anymore. I have not time to dig how to handle it better so I just made a copy of the old one .

@friedjoff
Copy link
Member

I have not time to dig how to handle it better so I just made a copy of the old one .

Currently I also have no time, but I created a new issue #141 so we don't forget to refactor (hopefully).

Copy link
Member

@friedjoff friedjoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@oterral oterral merged commit 2cf4060 into master Oct 1, 2019
@oterral oterral deleted the olivier/ol62 branch April 14, 2023 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants